Improve error message for failed p4p put #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomtrafford
force-pushed
the
improve_p4p_errorhandling
branch
from
abf2f4c
to
478b3c5
Compare
callumforrester
requested changes
Feb 22, 2024
There was a problem hiding this comment.
Looks good, please could you write a test similar to this one for CA:
ophyd-async/tests/epics/demo/test_demo.py
Line 149 in 641894d
|
Looks good now, thanks! Just needs rebasing on top of main and the linting needs fixing. |
tomtrafford
force-pushed
the
improve_p4p_errorhandling
branch
from
383bf7f
to
8421f1f
Compare
|
This is now re-based, and the linting is fixed. |
callumforrester
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds further information to the error when a PVA put function times-out and can't find the PV it was connecting to. This resolves #109