Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't harcode HDFFile dataset location #73

Closed
rosesyrett opened this issue Nov 13, 2023 · 3 comments · Fixed by #235
Closed

Don't harcode HDFFile dataset location #73

rosesyrett opened this issue Nov 13, 2023 · 3 comments · Fixed by #235
Assignees
Labels
hackathon Good issues for the upcoming bluesky hackathon

Comments

@rosesyrett
Copy link
Collaborator

At the moment there is just a hardcoded string in the HDFWriter indicating any data written by scans will be stored in 'entry/data/data'.
This is fine for our current use case (i22), except it'd be better to not hardcode this and consider the wider implications of that, i.e. do we make this a soft signal and have that set in the plan?

rosesyrett pushed a commit that referenced this issue Nov 13, 2023
In the default structure /entry/data is a NXdata group not the actual
dataset, therefore the path needs to be /entry/data/data.

In future this should not be hardcoded, see #73
@coretl
Copy link
Collaborator

coretl commented Nov 13, 2023

ADCore HDF writer will always write there unless you override it by providing a NeXus template xml for it to use. We should ensure that is blank and then we can rely on it always being /entry/data/data

@coretl
Copy link
Collaborator

coretl commented Apr 16, 2024

Still need to ensure that we add self.xml_file_name = ad_rw(prefix + "XMLFileName") and set it to "" before we open the HDF file as per https://areadetector.github.io/areaDetector/ADCore/NDFileHDF5.html#parameters-and-records

@callumforrester callumforrester added the hackathon Good issues for the upcoming bluesky hackathon label Apr 16, 2024
@Villtord
Copy link
Contributor

How can I test if I change path in HDFWriter? I would like to investigate "real" (in terms of existence) nexus or hdf file structure before/after my change. Will any of the detectors from docs/user/examples/epics_demo.py write actual hdf file in a dev container?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hackathon Good issues for the upcoming bluesky hackathon
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants