Skip to content

Commit

Permalink
fixed a bug in the metadata_fields and value_fields
Browse files Browse the repository at this point in the history
  • Loading branch information
evalott100 committed Mar 8, 2024
1 parent 519188f commit fe3e412
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
12 changes: 12 additions & 0 deletions src/ophyd_async/epics/_backend/_p4p.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,18 @@ def value(self, value: Value):
def descriptor(self, source: str, value) -> Descriptor:
raise NotImplementedError("Describing Dict signals not currently supported")

def metadata_fields(self) -> List[str]:
"""
Fields to request from PVA for metadata.
"""
return []

def value_fields(self) -> List[str]:
"""
Fields to request from PVA for the value.
"""
return []


class DisconnectedPvaConverter(PvaConverter):
def __getattribute__(self, __name: str) -> Any:
Expand Down
2 changes: 1 addition & 1 deletion tests/epics/test_signals.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
import pytest
from aioca import CANothing, purge_channel_caches
from bluesky.protocols import Reading

from ophyd_async.core import SignalBackend, T, get_dtype, load_from_yaml, save_to_yaml
from ophyd_async.core.utils import NotConnected
from ophyd_async.epics.signal._epics_transport import EpicsTransport
Expand Down Expand Up @@ -398,6 +397,7 @@ async def test_pvi_structure(ioc: IOC) -> None:
await backend.get_descriptor()
# Check initial value
await q.assert_updates(expected)
await backend.get_value()

finally:
q.close()
Expand Down

0 comments on commit fe3e412

Please sign in to comment.