Skip to content

Commit

Permalink
(#325) Fix typing issues in MockSignalBackend
Browse files Browse the repository at this point in the history
  • Loading branch information
DominicOram authored and abbiemery committed May 28, 2024
1 parent 39dbff6 commit 4da1550
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
9 changes: 3 additions & 6 deletions src/ophyd_async/core/mock_signal_backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from ophyd_async.core.utils import DEFAULT_TIMEOUT, ReadingValueCallback, T


class MockSignalBackend(SignalBackend):
class MockSignalBackend(SignalBackend[T]):
def __init__(
self,
datatype: Optional[Type[T]] = None,
Expand All @@ -31,11 +31,11 @@ def __init__(

if not isinstance(self.initial_backend, SoftSignalBackend):
# If the backend is a hard signal backend, or not provided,
# then we create a soft signal to mimick it
# then we create a soft signal to mimic it

self.soft_backend = SoftSignalBackend(datatype=datatype)
else:
self.soft_backend = initial_backend
self.soft_backend = self.initial_backend

def source(self, name: str) -> str:
if self.initial_backend:
Expand Down Expand Up @@ -65,9 +65,6 @@ async def put(self, value: Optional[T], wait=True, timeout=None):
def set_value(self, value: T):
self.soft_backend.set_value(value)

async def get_descriptor(self, source: str) -> Descriptor:
return await self.soft_backend.get_descriptor(source)

async def get_reading(self) -> Reading:
return await self.soft_backend.get_reading()

Expand Down
2 changes: 1 addition & 1 deletion src/ophyd_async/core/signal_backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class SignalBackend(Generic[T]):

#: Like ca://PV_PREFIX:SIGNAL
@abstractmethod
def source(name: str) -> str:
def source(self, name: str) -> str:
"""Return source of signal. Signals may pass a name to the backend, which can be
used or discarded."""

Expand Down

0 comments on commit 4da1550

Please sign in to comment.