Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Model <---> View-model contract #97

Merged
merged 8 commits into from
Jan 27, 2021

Commits on Jan 25, 2021

  1. Rename with sed.

    I have two motivations for this:
    
    1. Within the context of user code, what we have been calling
       FigureSpec is the complete user-facing description of "the figure".
       Thus, I am in the habit of using the local variable name `figure`
       for instances of FigureSpec. @jklynch pointed out that this is
       confusing. If we just call the call Figure, this inconsistency goes
       away.
    2. I want to shorten the names in preparation for potentially adding
       varieties.
    danielballan committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    475b594 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. Major refactor of View-model <--> Model contract

    - Make Artists aware only on update(), not BlueskyRun details.
    - Make Axes know about Artists, not separating specific types.
    danielballan committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    897bcb2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3720324 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eab4db9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ca39f95 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2021

  1. Configuration menu
    Copy the full SHA
    0fec3ea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a4963fd View commit details
    Browse the repository at this point in the history
  3. Update docstring.

    danielballan committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    c4c0aa2 View commit details
    Browse the repository at this point in the history