Update Chinese & Cantonese localization #7235
Open
+310
−346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auroursa
commented
Dec 21, 2024
| // Simplified Chinese to zh-CN | ||
| locale.languageTag = 'zh-CN' | ||
| if ( | ||
| locale.languageTag === 'zh-CN' || |
There was a problem hiding this comment.
To ensure browser compatibility, as browsers still widely use RFC-1766.
| locale.languageTag = 'zh-CN' | ||
| if ( | ||
| locale.languageTag === 'zh-CN' || | ||
| locale.languageTag.startsWith('zh-Hans') |
There was a problem hiding this comment.
There are multiple zh-Hans / zh-Hant variants on iOS and Android, such as zh-Hans-SG. We want to match as many of these language variants as possible.
Because it’s unlikely to maintain so many Chinese variants at this stage.
| // Traditional Chinese to zh-TW | ||
| locale.languageTag = 'zh-TW' | ||
| } | ||
| if (locale.languageTag.startsWith('yue')) { |
There was a problem hiding this comment.
After renaming zh-HK to yue, this is no longer needed.
|
I have considered directly using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the latest translations from Crowdin, and cleans up outdated strings.
Update: We are attempting to convert the language codes for Chinese and Cantonese from RFC-1766 to RFC-4646, to resolve language-related compatibility issues.
The following are the changes:
zh-CN->zh-Hans-CNzh-TW->zh-Hant-TWzh-HK->yueThe compatibility issue on Android stems from the differences in Hermes implementation of
Intl. On Android, it is based on the ICU4j project, which does not include RFC 1766 Chinese language codes likezh-CN. This will be an attempt to fix #6728 without introducing polyfills.Similar to
ast#6774,yuehas been proven to be a valid language code for app language. Tests have shown thatzh-Hans-CNandzh-Hant-TWcan also be correctly used by app language.Since these code changes are all related to Chinese adjustments (including modifications to deviceLocales.ts), I’ve included them in the regular Chinese localization update PR instead of opening a new one. This also helps our translators test the impact of the changes earlier.
Note the impact of changing the language code is limited to the app display language, Cantonese still cannot be used as post language.
Co-maintained by @cirx1e @hakadao @VentusUta