Remove rounding mode hack #7055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
samuel/rounding-upstream - social-app PR #7055
Render
Destroyed
|
This reverts commit f1b448e.
arcalinea
temporarily deployed
to
samuel/rounding-upstream - social-app PR #7055
Render
Destroyed
|
We can just delete those tests |
arcalinea
temporarily deployed
to
samuel/rounding-upstream - social-app PR #7055
Render
Destroyed
auroursa
added a commit
to auroursa/bsky-app-zh
that referenced
this pull request
Dec 12, 2024
gaearon
pushed a commit
that referenced
this pull request
Dec 16, 2024
* Fix post time localization on native * Fix timezone * Revent time.ts * Add time.android.ts * Add missing 'an' and 'ast' * Revent PostThreadItem.tsx * Resolve duplicate versions in lockfile * Move to time.native.ts * Follow #7055 to upgrade intl-datetimeformat version * Remove time.native.ts
Signez
pushed a commit
to Signez/bsky-social-app
that referenced
this pull request
Dec 26, 2024
* bump formatjs and remove hack * maybe fix tests? * Revert "maybe fix tests?" This reverts commit f1b448e. * rm test
Signez
pushed a commit
to Signez/bsky-social-app
that referenced
this pull request
Dec 26, 2024
* Fix post time localization on native * Fix timezone * Revent time.ts * Add time.android.ts * Add missing 'an' and 'ast' * Revent PostThreadItem.tsx * Resolve duplicate versions in lockfile * Move to time.native.ts * Follow bluesky-social#7055 to upgrade intl-datetimeformat version * Remove time.native.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
formatjs/formatjs#4678 was fixed upstream, so we can remove the hack
English:
Japanese:
Test plan
Round some numbers in various languages, and compare to the browser version