Edit profile dialog ALF refresh #5633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
arcalinea
temporarily deployed
to
samuel/edit-profile-refresh - social-app PR #5633
Render
Destroyed
mozzius
force-pushed
the
samuel/edit-profile-refresh
branch
from
3628b68 to
4cadd35
Compare
arcalinea
temporarily deployed
to
samuel/edit-profile-refresh - social-app PR #5633
Render
Destroyed
mozzius
changed the title
mozzius
force-pushed
the
samuel/edit-profile-refresh
branch
from
62f074f to
ea58c8c
Compare
mozzius
changed the title
mozzius
force-pushed
the
samuel/edit-profile-refresh
branch
from
ea58c8c to
64fbc56
Compare
mozzius
force-pushed
the
samuel/edit-profile-refresh
branch
from
484598a to
7a36141
Compare
|
Hmm, I'm getting an error whenever I hover over the buttons. Screen.Recording.2024-10-14.at.5.35.01.PM.movFwiw I also removed the portal logic locally, though didnt push. Dont think it is related to that though. |
mozzius
force-pushed
the
samuel/edit-profile-refresh
branch
from
a0c44ad to
10d3042
Compare
arcalinea
temporarily deployed
to
samuel/edit-profile-refresh - social-app PR #5633
Render
Destroyed
arcalinea
temporarily deployed
to
samuel/edit-profile-refresh - social-app PR #5633
Render
Destroyed
|
Nice, tested all three platforms. Found an android bug that I pushed a fix for as well. |
haileyok
approved these changes
Oct 15, 2024
|
The Pull Request introduced fingerprint changes against the base commit: Fingerprint diff[{"type":"file","filePath":"package.json","reasons":["expoConfigPlugins"],"hash":"a35a7f003a5d5a3e9ce15d4f576d7885bc5ad177"},{"type":"dir","filePath":"modules/bottom-sheet/android","reasons":["expoAutolinkingAndroid"],"hash":"d70d1b87050be634fffaf40a4205abd0da78b102"}]Generated by PR labeler 🤖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #5648
ALF refresh of the edit profile screen. Now tracks if the form is in a dirty state, and shows a warning if you try and cancel.
There is also a character limit warning.
The actual processing/saving logic remains the same as before.
I have added a new reusable
<Dialog.Header>component that you can pass to a newheaderpropTest plan
Can edit bio, same as before. The "discard changes" warning should only show after starting to edit. Test character limit (64 and 256 respectively)
Keyboard should work on web, thanks to the PR this is based on