Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch link previews from RQ #5608

Merged
merged 31 commits into from
Oct 8, 2024
Merged

Fetch link previews from RQ #5608

Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
3bd0cf2
Scaffold async record/media resolution when posting
gaearon Oct 4, 2024
73bc85c
Implement resolving for records and links
gaearon Oct 4, 2024
9aca51c
Remove now-unused publish options
gaearon Oct 4, 2024
fb9c9e4
Move function
gaearon Oct 4, 2024
bf00e09
Fix quotes
gaearon Oct 4, 2024
1cab152
Cache link/embed resolution in RQ
gaearon Oct 4, 2024
98297d3
Copy-paste ExternalEmbed into a condition forked by extGif
gaearon Oct 5, 2024
73b59e7
Prune dead branches
gaearon Oct 5, 2024
e5e2827
Copypaste ExternalEmbed into ExternalEmbedGif/Link
gaearon Oct 5, 2024
9c054b7
Prune dead branches
gaearon Oct 5, 2024
f17d0d9
Populate ExternalEmbedGif from RQ
gaearon Oct 5, 2024
6480db8
Populate ExternalEmbedLink from RQ
gaearon Oct 5, 2024
fad5ee7
Handle record embeds like before
gaearon Oct 4, 2024
1f70c67
Derive extGif from composer state
gaearon Oct 5, 2024
de97ecd
Use composer state for gif alt check
gaearon Oct 5, 2024
54a2151
Split GifEmbed props
gaearon Oct 5, 2024
79947b7
Populate GifAltText from RQ
gaearon Oct 5, 2024
599f989
Delete extLink and useExternalLinkFetch
gaearon Oct 5, 2024
98a51bb
Fix GIF not showing
gaearon Oct 5, 2024
befdb31
Just use the uri
gaearon Oct 5, 2024
8e5f816
Move constant
gaearon Oct 5, 2024
63045b1
Load quote via RQ
gaearon Oct 5, 2024
a9f55fb
Remove quote waitFor
gaearon Oct 6, 2024
301796a
Preload quotes
gaearon Oct 6, 2024
b312de9
Revert "Remove quote waitFor"
gaearon Oct 6, 2024
846e62c
Fix waiting for quote appview
gaearon Oct 6, 2024
0fe428d
Prettier
gaearon Oct 6, 2024
ce838f4
Remove stale todo
gaearon Oct 6, 2024
24eb8c2
Merge remote-tracking branch 'origin/main' into embed-7
haileyok Oct 7, 2024
637c99a
Merge remote-tracking branch 'origin/embed-7' into embed-8
haileyok Oct 7, 2024
462bc05
Merge branch 'main' into embed-8
haileyok Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 32 additions & 29 deletions src/App.native.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ import {
} from '#/state/session'
import {readLastActiveAccount} from '#/state/session/util'
import {Provider as ShellStateProvider} from '#/state/shell'
import {Provider as ComposerProvider} from '#/state/shell/composer'
import {Provider as LoggedOutViewProvider} from '#/state/shell/logged-out'
import {Provider as ProgressGuideProvider} from '#/state/shell/progress-guide'
import {Provider as SelectedFeedProvider} from '#/state/shell/selected-feed'
Expand Down Expand Up @@ -125,35 +126,37 @@ function InnerApp() {
// Resets the entire tree below when it changes:
key={currentAccount?.did}>
<QueryProvider currentDid={currentAccount?.did}>
<StatsigProvider>
<MessagesProvider>
{/* LabelDefsProvider MUST come before ModerationOptsProvider */}
<LabelDefsProvider>
<ModerationOptsProvider>
<LoggedOutViewProvider>
<SelectedFeedProvider>
<HiddenRepliesProvider>
<UnreadNotifsProvider>
<BackgroundNotificationPreferencesProvider>
<MutedThreadsProvider>
<ProgressGuideProvider>
<GestureHandlerRootView
style={s.h100pct}>
<TestCtrls />
<Shell />
<NuxDialogs />
</GestureHandlerRootView>
</ProgressGuideProvider>
</MutedThreadsProvider>
</BackgroundNotificationPreferencesProvider>
</UnreadNotifsProvider>
</HiddenRepliesProvider>
</SelectedFeedProvider>
</LoggedOutViewProvider>
</ModerationOptsProvider>
</LabelDefsProvider>
</MessagesProvider>
</StatsigProvider>
<ComposerProvider>
<StatsigProvider>
<MessagesProvider>
{/* LabelDefsProvider MUST come before ModerationOptsProvider */}
<LabelDefsProvider>
<ModerationOptsProvider>
<LoggedOutViewProvider>
<SelectedFeedProvider>
<HiddenRepliesProvider>
<UnreadNotifsProvider>
<BackgroundNotificationPreferencesProvider>
<MutedThreadsProvider>
<ProgressGuideProvider>
<GestureHandlerRootView
style={s.h100pct}>
<TestCtrls />
<Shell />
<NuxDialogs />
</GestureHandlerRootView>
</ProgressGuideProvider>
</MutedThreadsProvider>
</BackgroundNotificationPreferencesProvider>
</UnreadNotifsProvider>
</HiddenRepliesProvider>
</SelectedFeedProvider>
</LoggedOutViewProvider>
</ModerationOptsProvider>
</LabelDefsProvider>
</MessagesProvider>
</StatsigProvider>
</ComposerProvider>
</QueryProvider>
</React.Fragment>
</VideoVolumeProvider>
Expand Down
57 changes: 30 additions & 27 deletions src/App.web.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ import {
} from '#/state/session'
import {readLastActiveAccount} from '#/state/session/util'
import {Provider as ShellStateProvider} from '#/state/shell'
import {Provider as ComposerProvider} from '#/state/shell/composer'
import {useComposerKeyboardShortcut} from '#/state/shell/composer/useComposerKeyboardShortcut'
import {Provider as LoggedOutViewProvider} from '#/state/shell/logged-out'
import {Provider as ProgressGuideProvider} from '#/state/shell/progress-guide'
Expand Down Expand Up @@ -116,33 +117,35 @@ function InnerApp() {
// Resets the entire tree below when it changes:
key={currentAccount?.did}>
<QueryProvider currentDid={currentAccount?.did}>
<StatsigProvider>
<MessagesProvider>
{/* LabelDefsProvider MUST come before ModerationOptsProvider */}
<LabelDefsProvider>
<ModerationOptsProvider>
<LoggedOutViewProvider>
<SelectedFeedProvider>
<HiddenRepliesProvider>
<UnreadNotifsProvider>
<BackgroundNotificationPreferencesProvider>
<MutedThreadsProvider>
<SafeAreaProvider>
<ProgressGuideProvider>
<Shell />
<NuxDialogs />
</ProgressGuideProvider>
</SafeAreaProvider>
</MutedThreadsProvider>
</BackgroundNotificationPreferencesProvider>
</UnreadNotifsProvider>
</HiddenRepliesProvider>
</SelectedFeedProvider>
</LoggedOutViewProvider>
</ModerationOptsProvider>
</LabelDefsProvider>
</MessagesProvider>
</StatsigProvider>
<ComposerProvider>
<StatsigProvider>
<MessagesProvider>
{/* LabelDefsProvider MUST come before ModerationOptsProvider */}
<LabelDefsProvider>
<ModerationOptsProvider>
<LoggedOutViewProvider>
<SelectedFeedProvider>
<HiddenRepliesProvider>
<UnreadNotifsProvider>
<BackgroundNotificationPreferencesProvider>
<MutedThreadsProvider>
<SafeAreaProvider>
<ProgressGuideProvider>
<Shell />
<NuxDialogs />
</ProgressGuideProvider>
</SafeAreaProvider>
</MutedThreadsProvider>
</BackgroundNotificationPreferencesProvider>
</UnreadNotifsProvider>
</HiddenRepliesProvider>
</SelectedFeedProvider>
</LoggedOutViewProvider>
</ModerationOptsProvider>
</LabelDefsProvider>
</MessagesProvider>
</StatsigProvider>
</ComposerProvider>
</QueryProvider>
<ToastContainer />
</React.Fragment>
Expand Down
Loading
Loading