Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix profile header buttons #5558

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Fix profile header buttons #5558

merged 6 commits into from
Oct 3, 2024

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented Oct 1, 2024 •
edited
Loading

Noticed some misalignment here, and now that we're reigning in our button styles, this is one of the most important spots.

This makes a few small adjustments:

  • removes custom styling from these buttons, except for the border radius
  • replaces overflow menu button with Button
  • reduced gap between buttons, looks sharper now
  • removes the hacky web({ top: -0.4 }) that I added, def not right, unneeded imo
  • bumps up the small button size by 2px, was just def too small
  • reduces size of small/round button by 4px, the "optical sizing" I was going for wasn't right here for small buttons, still looks good on large size though

CleanShot 2024-10-01 at 16 40 30@2x
CleanShot 2024-10-01 at 16 40 34@2x
CleanShot 2024-10-01 at 16 40 24@2x
CleanShot 2024-10-01 at 16 49 30@2x
CleanShot 2024-10-01 at 16 39 57@2x
CleanShot 2024-10-01 at 16 39 51@2x
CleanShot 2024-10-01 at 16 40 00@2x
CleanShot 2024-10-01 at 16 49 45@2x

@arcalinea arcalinea temporarily deployed to fix-prof-head-buttons - social-app PR #5558 October 1, 2024 21:44 — with Render Destroyed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024 •
edited
Loading

Old size New size Diff
7.91 MB 7.91 MB -23 B (-0.00%)

@estrattonbailey
Merge remote-tracking branch 'origin/main' into fix-prof-head-buttons
e58cd68 
* origin/main:
  🪵📌 (#5594)
  Rename some files and variables (#5587)
  Manage video reducer from composer reducer (#5573)
  Refactor video uploads (#5570)
  Delete messages NUX (#5574)
  move files around (#5576)
  Make reply prompt more subtle on desktop (#5569)
  Ignore built files (#5572)
  import order (#5571)
  Add suspense boundary in onboarding (#5556)
  Tweak verify email dialog (#5555)
  Add intent/verify-email to go server (#5554)
@estrattonbailey
Fix load state jumps
ca447c6
@estrattonbailey
Small tweak for web
60471d7
@arcalinea arcalinea temporarily deployed to fix-prof-head-buttons - social-app PR #5558 October 3, 2024 15:09 — with Render Destroyed
mozzius
mozzius approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@mozzius mozzius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@arcalinea arcalinea temporarily deployed to fix-prof-head-buttons - social-app PR #5558 October 3, 2024 15:16 — with Render Destroyed
@estrattonbailey estrattonbailey merged commit eb3b01d into main Oct 3, 2024
6 checks passed
tkusano pushed a commit to tkusano/social-app that referenced this pull request Oct 4, 2024
@estrattonbailey @tkusano
Fix profile header buttons (bluesky-social#5558)
c00c5fa 
* Fix profile header buttons

* Adjust labeler buttons too

* Fix load state jumps

* Small tweak for web

* Remove log
tkusano added a commit to tkusano/social-app that referenced this pull request Oct 4, 2024
@tkusano
Revert "Fix profile header buttons (bluesky-social#5558)"
e928cd1 
This reverts commit c00c5fa.
estrattonbailey added a commit that referenced this pull request Oct 7, 2024
@tkusano @gaearon
@mozzius @estrattonbailey
Update Japanese translation (#5374)
c365096 
* Update translation

* Fixed

* Update translation

* Update translation

* Update translation

* Update translation

* Suggested fix by Hima-Zinn

* Update translation

* Update translation

* Update translation

* Translate "pinned"

* Update translation

* Refactor video uploads (#5570)

* Remove unused video field

* Stop exposing video dispatch

* Move cancellation out of the reducer

* Make useUploadStatusQuery controlled by jobId

* Rename SetStatus to SetProcessing

This action only has one callsite and it's always passing "processing".

* Move jobId into video reducer state

* Make cancellation scoped

* Inline useCompressVideoMutation

* Move processVideo down the file

* Extract getErrorMessage

* useServiceAuthToken -> getServiceAuthToken

* useVideoAgent -> createVideoAgent

* useVideoUploadLimits -> getVideoUploadLimits

* useUploadVideoMutation -> uploadVideo

* Use async/await in processVideo

* Inline onVideoCompressed into processVideo

* Use async/await for uploadVideo

* Factor out error messages

* Guard dispatch with signal

This lets us remove the scattered signal checks around dispatch.

* Move job polling out of RQ

* Handle poll failures

* Remove unnecessary guards

* Slightly more accurate condition

* Move initVideoUri handling out of the hook

* Remove dead argument

It wasn't being used before either.

* Remove unused detailed status

This isn't being used because we're only respecting that state variable when isProcessing=true, but isProcessing is always false during video upload.

If we want to re-add this later, it should really just be derived from the reducer state.

* Harden the video reducer

* Tie all spawned work to a signal

* Preserve asset/media for nicer error state

* Rename actions to match states

* Inline useUploadVideo

This abstraction is getting in the way of some future work.

* Move MIME check to the only place that handles it

* Manage video reducer from composer reducer (#5573)

* Move video state into composer state

* Represent video as embed

This is slightly broken. In particular, we can't remove video yet because there's no action that results in video embed being removed.

* Properly represent video as embed

This aligns the video state lifetime with the embed lifetime. Video can now be properly added and removed.

* Disable Add Video when we have images

* Ignore empty image pick

* Rename some files and variables (#5587)

* Move composer reducers together

* videoUploadState -> videoState

* Inline videoDispatch

* 🪵📌 (#5594)

* [🐴] Reduce amount that message sent date is shown (#4228)

* Fix profile header buttons (#5558)

* Fix profile header buttons

* Adjust labeler buttons too

* Fix load state jumps

* Small tweak for web

* Remove log

* Update

* Revert "Update"

This reverts commit b073c04.

* Revert "Fix profile header buttons (#5558)"

This reverts commit c00c5fa.

* Revert "[🐴] Reduce amount that message sent date is shown (#4228)"

This reverts commit af8e342.

* Revert "🪵📌 (#5594)"

This reverts commit 3ab5190.

* Revert "Rename some files and variables (#5587)"

This reverts commit 475708e.

* Revert "Manage video reducer from composer reducer (#5573)"

This reverts commit 59589e3.

* Revert "Refactor video uploads (#5570)"

This reverts commit f74f9bc.

* Update translation

* Update translation

* Delete unused entries

* Restored the trailing dot by #5622

---------

Co-authored-by: dan <[email protected]>
Co-authored-by: Samuel Newman <[email protected]>
Co-authored-by: Eric Bailey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mozzius mozzius mozzius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estrattonbailey @mozzius @arcalinea