Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: always display next button in login page #5238

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

vinifsouza
Copy link
Contributor

To make the login page more intuitive, this PR changes the login page to always display the "next" button. When the data is not filled in, the button remains in a disabled state.

Before:
image

After:
!isReady
image

isReady
image

@bybruno
Copy link

bybruno commented Sep 11, 2024

This is a good alternative, it makes sense to show the next button 👏🏼

Generally, for better UX, it's recommended to keep the button enabled and if clicked with empty fields, an error message is displayed below the fields indicating to the user what needs to be filled in, and the button is disabled.

But your solution can be an intermediate step towards that.

@gaearon
Copy link
Collaborator

gaearon commented Sep 11, 2024

I agree it would be better to keep the button always visible and enabled (but show error if you try to press it while the form isn't filled out). Can we do that in this PR? Thanks.

@vinifsouza
Copy link
Contributor Author

vinifsouza commented Sep 12, 2024

Thanks @bybruno @gaearon

Done!

Login.mp4

I have added the same behavior to forgot password screen.

ForgotPassword.mp4

@bybruno
Copy link

bybruno commented Sep 13, 2024

LGTM!!!

@estrattonbailey estrattonbailey changed the base branch from main to eric/login-next September 13, 2024 16:53
Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thank you! Gonna merge into base and remove the isReady logic since that's unused now.

@estrattonbailey estrattonbailey merged commit adf9a22 into bluesky-social:eric/login-next Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants