[Video] Resume background audio whenever muting video audio #4915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4915.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cqr9pirv2p9s73drc8o0. |
|
The Pull Request introduced fingerprint changes against the base commit: Fingerprint diff[{"type":"dir","filePath":"modules/expo-bluesky-swiss-army/ios","reasons":["expoAutolinkingIos"],"hash":"85fd1f0c0f675717a0a05dac96a901fc0b7ee7ea"}]Generated by PR labeler 🤖 |
|
estrattonbailey
added a commit
that referenced
this pull request
Aug 15, 2024
* origin/main: (28 commits) swap control files (#4936) [Embed] Starter pack embed embed (#4935) [Video] set audio category to ambient every time a new player is made (#4934) Add `/live/` to supported YouTube embed URLs (#4932) [Video] Try/catch video play/pause (#4930) Don't kick to login screen on network error (#4911) Remove .withProxy() calls (#4929) [Video] Audio duck off main thread (#4926) subclass agent to add setPersistSessionHandler (#4928) [Video] Fix crash when switching tabs (#4925) [Video] Invert usage of `setAudioActive` (#4924) Upgrade API, implement XRPC rework (#4857) rm from swift (#4923) Fix Android composer cursor bug by removing `setTimeout` from native composer `onChangeText` (#4922) Show handle in recent searches and fix truncation (#4917) Improve styles (#4916) Mark string for localization (#4920) Fix `occurred` typo (#4919) [Video] Resume background audio whenever muting video audio (#4915) [Videos] Add error boundary to native (#4914) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We want the background audio to properly resume once we either mute the video audio or exit fullscreen. Let's do that.
How
See https://developer.apple.com/documentation/avfaudio/avaudiosession/setactiveoptions/1616603-notifyothersondeactivation
Test Plan
Merge, build, test.