Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐴] Option to share via chat in post dropdown #4231

Merged
merged 14 commits into from
May 31, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented May 27, 2024

Stacked on #4227 and #4230

Fixes #4215

Shares 99% of code with new chat dialog. Also includes new UI in the chat screen showing a preview of the post before setting it, along with an option to remove it before sending

Screenshot 1 Screenshot 2 Screenshot 3 Screenshot 4
Simulator Screenshot - iPhone 15 - 2024-05-28 at 14 21 00 Simulator Screenshot - iPhone 15 - 2024-05-28 at 14 21 08 Simulator Screenshot - iPhone 15 - 2024-05-28 at 14 21 24 Simulator Screenshot - iPhone 15 - 2024-05-28 at 14 21 32

Copy link

render bot commented May 27, 2024

Copy link

github-actions bot commented May 27, 2024

Old size New size Diff
7.39 MB 7.39 MB -88 B (-0.00%)

@mozzius mozzius marked this pull request as ready for review May 28, 2024 12:21
@mozzius mozzius force-pushed the samuel/share-record branch from eb5cd47 to 4fe373e Compare May 29, 2024 09:06
@estrattonbailey estrattonbailey changed the base branch from main to samuel/see-record May 30, 2024 17:57
Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking so good!

@estrattonbailey estrattonbailey changed the base branch from samuel/see-record to main May 31, 2024 15:43
mozzius and others added 14 commits May 31, 2024 10:54
(cherry picked from commit d8458c0bc344f993266f7bc7e325d47e40619648)
(cherry picked from commit 16b577ce749fd07e1d5f8461e8ca71c5b874a936)
(cherry picked from commit 795ceb98d55b6a3ab5b83187a582f9656d71db69)
(cherry picked from commit 374d6b8869459f08d8442a3a47d67149e8d9ddd4)
(cherry picked from commit c20e0062c2ca4d9c2b28324eee5e713a1a3ab251)
(cherry picked from commit 5bb617a3ce00f67bfc79784b2f81ef8dcb5bfc25)
(cherry picked from commit ee120d5438a2c91c8980288665576d6a29b4c7e7)
(cherry picked from commit 5297a5b06e499f46a9f6da510124610005db2448)
(cherry picked from commit bc7e9f6a4303926a53c5c889f1f1b136faf20491)
(cherry picked from commit 9e3ccb0f25ac2f3ce6af538bb29112a3e96e01b1)
(cherry picked from commit cc0b84db87ca812d76cc69f46170ae84cfdde4ef)
(cherry picked from commit 9c49b940e1248e8a7c3b64190c5cb20750043619)
(cherry picked from commit 1186701c997c50c0b29a809637cb9bc061b8c0a0)
(cherry picked from commit 8868d5075062d0199c8ef6946fabde27e46ea378)
@estrattonbailey estrattonbailey merged commit cd3b502 into main May 31, 2024
6 checks passed
estrattonbailey added a commit that referenced this pull request May 31, 2024
* origin/main: (51 commits)
  [🐴] Option to share via chat in post dropdown (#4231)
  [🐴] Record message (#4230)
  [🐴] send record via link in text (Record DMs - base PR) (#4227)
  Use new icons on notifications screen (#4299)
  Composer - fix modals, and other tweaks (#4298)
  Shadows (#4265)
  Change many border widths from `1` to `hairlineWidth` (#4294)
  Add follow button to feed item avatar (#3560)
  Disable non-deterministic flaky test (#4295)
  Don't log downsample warning when unnecessary (#4291)
  [Statsig] Sample noisy events (#4288)
  Bump FontAwesome (#4285)
  Fix scrolling for labeler profiles (#4286)
  Reduce Threadgate button size (#4287)
  put dropdown in fullscreenoverlay on iOS (#4284)
  play haptics before closing modal (#4283)
  match loadmore position to fab (#4280)
  Composer - Use sheet presentation on iOS (#4278)
  don't maintain position whenever there are no parents (#4277)
  Fix native translations on iOS 17.5.1 (#4282)
  ...
estrattonbailey added a commit that referenced this pull request May 31, 2024
* origin/main: (37 commits)
  fix accessibility label in notifications (#4305)
  [🐴] add emoji multiplier prop to RichText and bump it up for DMs (#4229)
  Tweak avi follow button styles (#4304)
  [🐴] Embed backwards compat (#4302)
  [🐴] Add labels to chats (#4293)
  [🐴] Option to share via chat in post dropdown (#4231)
  [🐴] Record message (#4230)
  [🐴] send record via link in text (Record DMs - base PR) (#4227)
  Use new icons on notifications screen (#4299)
  Composer - fix modals, and other tweaks (#4298)
  Shadows (#4265)
  Change many border widths from `1` to `hairlineWidth` (#4294)
  Add follow button to feed item avatar (#3560)
  Disable non-deterministic flaky test (#4295)
  Don't log downsample warning when unnecessary (#4291)
  [Statsig] Sample noisy events (#4288)
  Bump FontAwesome (#4285)
  Fix scrolling for labeler profiles (#4286)
  Reduce Threadgate button size (#4287)
  put dropdown in fullscreenoverlay on iOS (#4284)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to 'Share post via chat' using the post dropdown menu
2 participants