-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use custom github action for fingerprinting #4226
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
9deee71
use custom github action for fingerprinting
haileyok 6c65dd3
update pr workflow
haileyok a46fc57
update names of workflows
haileyok 8db9835
make a native change (testing)
haileyok 1e8b7bc
adjust the action
haileyok fc1711f
Revert "make a native change (testing)"
haileyok b06e3ff
update bundle-deploy script
haileyok 8a1e61a
test a prod build
haileyok 205bec8
crazy depth
haileyok cd6719f
manually set
haileyok 1093579
use prod default
haileyok 763a16a
force prod
haileyok 391a7ad
revert test changes
haileyok c8a908a
Merge branch 'main' into hailey/improve-github-action-fingerprint
haileyok a274442
save cache after deploy
haileyok e576a2a
revert testing
haileyok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The custom action will handle installing dependencies, since it needs to install deps from both commits. Therefore, we are removing the
yarn install
step from this workflow.The action will:
Afterwards, we will have the proper deps installed, so there is no need to install them prior to running the fingerprint action.