Code

Small logic cleanups#3451

Code

Merged

haileyok merged 14 commits intodialogs-cleanupbluesky-social/social-app:dialogs-cleanupfrom hailey/dialogs-cleanupbluesky-social/social-app:hailey/dialogs-cleanupCopy head branch name to clipboardApr 9, 2024

+186-45

Commits

Commits on Apr 9, 2024

• remove a few things

  haileyok

  committed
  d7c7cab

• oops

  haileyok

  committed
  7af74dc

• stop swallowing the error

  haileyok

  committed
  deb4b27

• queue callbacks

  haileyok

  committed
  121840c

• oops

  haileyok

  committed
  c9831f9

• log error if caught

  haileyok

  committed
  e98ebae

• no need to be nullable

  haileyok

  committed
  84d5ceb

• move isClosing=true up

  haileyok

  committed
  8dfc085

• reset isClosing and closeCallbacks on close completion and open

  haileyok

  committed
  bebdc8f

• run queued callbacks on open if there are any pending

  haileyok

  committed
  4042122

• rm unnecessary ref and check

  haileyok

  committed
  9f706f0

• ensure order of calls is always correct

  haileyok

  committed
  082d63d

• call snapToIndex() on open

  haileyok

  committed
  ef11e61

• add tester to storybook

  haileyok

  committed
  7982c8f