Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experiment] Turn off interval polling for Discover #3431

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Apr 6, 2024

The first commit adds the feed URL to the metadata so we can check metrics against individual feeds.

In the second commit, I add a feature gate that disables polling for Discover. The hypothesis is that the blue dot is getting people to refresh it more often instead of scrolling to the end, but the blue dot doesn't quite make sense for algo feeds where the content is always different. This removes the polling-based blue dot for Discover so we can check if this changes the user behavior. The blue dot will still appear when foregrounding the app.

We can run more variations on this experiment so this is just something to play with while learning how to do it.

Test Plan

Decreased polling interval to 5 seconds. Verified blue dot stopped getting blue on timer for the Discover feed. Still gets blue on timer for other feeds. Foregrounding still makes it blue for Discover.

@gaearon gaearon requested a review from pfrazee April 6, 2024 04:11
Copy link

github-actions bot commented Apr 6, 2024

Old size New size Diff
6.36 MB 6.36 MB 193 B (0.00%)

Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped this in Slack as well, but think there's a lot of experimentation we could do around this button. Might be worth considering just rming it completely at some point based on some user discussions.

@gaearon gaearon merged commit 8188f61 into main Apr 8, 2024
6 checks passed
@gaearon gaearon deleted the dont-poll-discover-xp branch April 8, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants