Update Japanese localization based on the latest codebase #2509

noritada · 2024-01-12T09:19:46Z

This PR updates Japanese localization based on the latest codebase (b147f7a).

Since many messages were marked for translation and context information was added to some messages, the number of untranslated messages in the latest codebase increased dramatically.

% # before reflecting changes in the latest code base
% LANG=C msgfmt --statistics src/locale/locales/ja/messages.po.
552 translated messages, 19 untranslated messages.

% # after reflecting changes in the latest code base
% LANG=C msgfmt --statistics src/locale/locales/ja/messages.po
542 translated messages, 344 untranslated messages.

% # after translation work
% LANG=C msgfmt --statistics src/locale/locales/ja/messages.po
744 translated messages, 142 untranslated messages.

In this PR, ja/messages.po was regenerated for the old codebase after the translation work was done to minimize diffs without making unnecessary changes, so the newly added messages are commented out (by running yarn intl:build on the old code base).
These messages should be auto-activated when the development team reflects the latest codebase into po files by yarn intl:build.

Dear @Hima-Zinn @tkusano @dolciss @oboenikui
I would appreciate your review and feedback on these text updates.

Many thanks!

oboenikui · 2024-01-12T10:22:32Z

src/locale/locales/ja/messages.po

+
+#: src/view/com/modals/AddAppPasswords.tsx:133
+#~ msgid "App Password names can only contain letters, numbers, spaces, dashes, and underscores."
+#~ msgstr "アプリパスワードの名前には、文字、数字、スペース、ハイフン、アンダースコアのみが使用可能です。"


In Japanese, "文字" refers to a variety of characters, but the specifications seem to refer to English letters.

Suggested change

#~ msgstr "アプリパスワードの名前には、文字、数字、スペース、ハイフン、アンダースコアのみが使用可能です。"

#~ msgstr "アプリパスワードの名前には、英数字、スペース、ハイフン、アンダースコアのみが使用可能です。"

Also need to fix this line:

social-app/src/locale/locales/ja/messages.po

Line 488 in e3a958b

msgstr "文字、数字、スペース、ハイフン、およびアンダースコアのみが使用可能です。長さは4文字以上32文字以下である必要があります。"

Thank you!

I made the translation to match the existing translation, but I was also concerned about it. You are right, I should change it.

Perhaps that is a remnant of the translation I did, so please change it to that one if you like.

noritada · 2024-01-12T10:53:22Z

I have updated to make changes suggested.
Feel free to provide feedbacks if you have any other concerns.

Hima-Zinn · 2024-01-12T12:06:14Z

I tried to edit the file and it created a fork and I edited it from there, but I don't know the GitHub specs and it didn't seem to merge there. What should I do?
#2511

noritada · 2024-01-12T12:28:15Z

@Hima-Zinn Thank you! I will be able to merge (after my supper).

Hima-Zinn · 2024-01-12T12:36:19Z

Thank you.

Please note that the header information (time, team, and others) is tentative and will need to be changed after various people have actually seen it, and that I have not incorporated @oboenikui's changes as I was not aware of them yet.

The code was too long, so if you can change the part I updated to something better, you should change it to that.

Co-authored-by: oboenikui <[email protected]>

Co-authored-by: Noritada Kobayashi <[email protected]>

noritada · 2024-01-12T16:43:15Z

Merged #2511 into this PR.

As for the header fields POT-Creation-Date and MIME-Version, I have reverted the changes back, as the other language teams have continued to use it without updating it from the beginning.

The changes I made based on @oboenikui's suggestions have indeed reverted to their previous state, so I have re-added them.

To clarify the changes, I have split into 3 commits.

my first comimt: e3a958b
update based on @oboenikui's suggestions: b301242
@Hima-Zinn's commit with minor changes by me: ca39488

tkusano

Looks good to me

dolciss

Thank you for the extensive changes.
I am sorry for the delay, but I have reviewed the contents and commented on some points, please confirm.

dolciss · 2024-01-13T07:00:47Z

src/locale/locales/ja/messages.po


 #: src/view/com/auth/onboarding/RecommendedFeedsItem.tsx:100
 msgid "by {0}"
-msgstr ""
+msgstr "{0}が作成"


前後の src/view/com/profile/ProfileSubpageHeader.tsx 「～により」と異なり
こちらだけ「～が作成」となっているのは意図がありますでしょうか？

どちらも次のように

カスタムフィード（リスト）名
by @ account

とフィードやリストの作成者を示す箇所かと思いますので、
統一してもいいかと思います。

個人的には

Suggested change

msgstr "{0}が作成"

msgstr "作成：{0}"

の方が良いかなと思いますが好みが分かれそうです。

追記：
src/view/screens/ProfileFeed.tsx ですと
Created by {0}が作成者：{0}とされていたので「作成者」でも良いです

dolciss · 2024-01-13T07:35:36Z

src/locale/locales/ja/messages.po

@@ -673,23 +673,23 @@ msgstr "ナビゲーションフッターを閉じる"

 #: src/view/shell/index.web.tsx:50
 msgid "Closes bottom navigation bar"
-msgstr ""
+msgstr "ボタンのナビゲーションバーを閉じる"


buttonではなくbottomですね……

Suggested change

msgstr "ボタンのナビゲーションバーを閉じる"

msgstr "下部のナビゲーションバーを閉じる"

dolciss · 2024-01-13T07:44:14Z

src/locale/locales/ja/messages.po


 #: src/view/com/composer/Composer.tsx:448
 msgid "Creates a card with a thumbnail. The card links to {url}"
-msgstr ""
+msgstr "サムネイル付きのカードを作成します。そのカードは次のリンクへリンクします：{url}"


リンクへリンクするは混乱しそうですね……

Suggested change

msgstr "サムネイル付きのカードを作成します。そのカードは次のリンクへリンクします：{url}"

msgstr "サムネイル付きのカードを作成します。そのカードは次のアドレスへリンクします：{url}"

dolciss · 2024-01-13T07:44:50Z

src/locale/locales/ja/messages.po


 #: src/view/screens/Debug.tsx:83
 msgid "Debug panel"
-msgstr ""
+msgstr "デバックパネル"


表記揺れ

Suggested change

msgstr "デバックパネル"

msgstr "デバッグパネル"

noritada · 2024-01-13T09:16:24Z

@dolciss Thank you! I have made changes suggested.

英語との語順が異なるので、by 〜は悩みますよね…。
（私も後回しにしがちでした。）

dolciss

Thank you for your quick response!
We would like to ask you to unify similar "by ~" messages as well.

dolciss · 2024-01-13T09:47:31Z

src/locale/locales/ja/messages.po


 #: src/view/com/profile/ProfileSubpageHeader.tsx:157
 msgid "by —"
-msgstr ""
+msgstr "—により"


Suggested change

msgstr "—により"

msgstr "作成者：—"

dolciss · 2024-01-13T09:47:45Z

src/locale/locales/ja/messages.po


 #: src/view/com/profile/ProfileSubpageHeader.tsx:161
 msgid "by <0/>"
-msgstr ""
+msgstr "<0/>により"


Suggested change

msgstr "<0/>により"

msgstr "作成者：<0/>"

dolciss · 2024-01-13T09:47:55Z

src/locale/locales/ja/messages.po


 #: src/view/com/profile/ProfileSubpageHeader.tsx:159
 msgid "by you"
-msgstr ""
+msgstr "あなたにより"


Suggested change

msgstr "あなたにより"

msgstr "作成者：あなた"

Co-authored-by: L-tan <[email protected]>

noritada · 2024-01-13T10:54:36Z

@dolciss Oops, fixed. Thank you very much!

noritada · 2024-01-17T11:05:16Z

Since the release of 1.65 caused conflicts again, I have merged the latest changes into po to resolve the conflicts and translated 9 new messages.

New 9 translations are as follows!
06c9a20

(A message "We ran out of posts from your follows..." should be improved from the viewpoint of l10n. I have made a fix and will send a PR.)

Hima-Zinn · 2024-01-18T04:06:32Z

I commented in Japanese about your commitments.
06c9a20#r137323683
(Please check from your PC or browser, as you cannot see my comments from the GitHub application.)

pfrazee · 2024-01-19T05:03:20Z

@noritada Hey apologies for the long turn-around. Are we ready to merge?

Hima-Zinn · 2024-01-19T10:40:07Z

I think it is time to merge. If there are any new translations or corrections, I also think it would be better to submit a new PR at that time.

noritada · 2024-01-21T18:13:17Z

@Hima-Zinn Thank you for your suggestion. I have updated as a468212.
It would be nice for you to add review comments using "Files changed" tab in this PR next time.
This doc in GitHub's official help will help you.

noritada · 2024-01-21T18:15:40Z

Since po conflicted, I have merged main branch with conflict resolution.
I have also translated 23 new messages.

noritada · 2024-01-21T18:16:24Z

@pfrazee Sorry for my late reply. Yes, we are ready to merge!

pfrazee

Thanks everyone! <3 merging!

* origin: (109 commits) Update Korean localization (#2494) fix: don't expose post content on no-unauthenticated (#2584) Tweak positioning use color scheme in in-app browser (#2580) Fix jump when opening last post in thread (#2591) Fix orphan replies in linear mode (#2578) Fix typos, improve localization and unify separators (#2502) Update Japanese localization based on the latest codebase (#2509) Update pt-BR translation (#2471) New Web Layout (#2126) Update src/locale/locales/id/messages.po Update src/locale/locales/id/messages.po Update src/locale/locales/id/messages.po Update src/locale/locales/id/messages.po Update src/locale/locales/id/messages.po Update src/locale/locales/id/messages.po Update src/locale/locales/id/messages.po Update src/locale/locales/id/messages.po Update src/locale/locales/id/messages.po Update src/locale/locales/id/messages.po ...

Update Japanese localization based on the latest codebase

e3a958b

oboenikui reviewed Jan 12, 2024

View reviewed changes

noritada force-pushed the l10n/ja-po-updates-20240112 branch from e3a958b to 86d5066 Compare January 12, 2024 10:44

Improve translations based on suggestions in reviews

b301242

Co-authored-by: oboenikui <[email protected]>

noritada force-pushed the l10n/ja-po-updates-20240112 branch from 86d5066 to 82b6c8f Compare January 12, 2024 16:10

Update messages.po

ca39488

Co-authored-by: Noritada Kobayashi <[email protected]>

noritada force-pushed the l10n/ja-po-updates-20240112 branch from 82b6c8f to ca39488 Compare January 12, 2024 16:28

tkusano reviewed Jan 12, 2024

View reviewed changes

pfrazee added the intl Internationalization label Jan 12, 2024

Merge branch 'main', resolving conflicts

94f1f0d

dolciss reviewed Jan 13, 2024

View reviewed changes

Make corrections and improvements suggested

2c2a906

Co-authored-by: L-tan <[email protected]>

noritada force-pushed the l10n/ja-po-updates-20240112 branch from e98b5f8 to 2c2a906 Compare January 13, 2024 10:53

noritada added 2 commits January 17, 2024 19:33

Merge main ('8c4e5b5'), resolving conflicts

0886134

Translate 9 new messages

06c9a20

noritada force-pushed the l10n/ja-po-updates-20240112 branch from 50e1a6e to 06c9a20 Compare January 17, 2024 10:58

pfrazee self-assigned this Jan 19, 2024

Improve a translation

a468212

noritada added 2 commits January 22, 2024 02:31

Merge main ('cd02922'), resolving conflicts

e3537e0

Translate 23 new messages

2b7b041

pfrazee approved these changes Jan 22, 2024

View reviewed changes

pfrazee merged commit abacc51 into bluesky-social:main Jan 22, 2024
3 of 4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Japanese localization based on the latest codebase #2509

Update Japanese localization based on the latest codebase #2509

noritada commented Jan 12, 2024 •

edited

Loading

oboenikui Jan 12, 2024 •

edited

Loading

noritada Jan 12, 2024

Hima-Zinn Jan 12, 2024

noritada commented Jan 12, 2024

Hima-Zinn commented Jan 12, 2024

noritada commented Jan 12, 2024

Hima-Zinn commented Jan 12, 2024 •

edited

Loading

noritada commented Jan 12, 2024

tkusano left a comment

dolciss left a comment

dolciss Jan 13, 2024

dolciss Jan 13, 2024

dolciss Jan 13, 2024

dolciss Jan 13, 2024

noritada commented Jan 13, 2024

dolciss left a comment

dolciss Jan 13, 2024

dolciss Jan 13, 2024

dolciss Jan 13, 2024

noritada commented Jan 13, 2024

noritada commented Jan 17, 2024

Hima-Zinn commented Jan 18, 2024 •

edited

Loading

pfrazee commented Jan 19, 2024

Hima-Zinn commented Jan 19, 2024

noritada commented Jan 21, 2024

noritada commented Jan 21, 2024

noritada commented Jan 21, 2024

pfrazee left a comment

	#~ msgstr "アプリパスワードの名前には、文字、数字、スペース、ハイフン、アンダースコアのみが使用可能です。"
	#~ msgstr "アプリパスワードの名前には、英数字、スペース、ハイフン、アンダースコアのみが使用可能です。"

	msgstr "ボタンのナビゲーションバーを閉じる"
	msgstr "下部のナビゲーションバーを閉じる"

	msgstr "サムネイル付きのカードを作成します。そのカードは次のリンクへリンクします：{url}"
	msgstr "サムネイル付きのカードを作成します。そのカードは次のアドレスへリンクします：{url}"

	msgstr "デバックパネル"
	msgstr "デバッグパネル"

Update Japanese localization based on the latest codebase #2509

Update Japanese localization based on the latest codebase #2509

Conversation

noritada commented Jan 12, 2024 • edited Loading

oboenikui Jan 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

noritada commented Jan 12, 2024

Hima-Zinn commented Jan 12, 2024

noritada commented Jan 12, 2024

Hima-Zinn commented Jan 12, 2024 • edited Loading

noritada commented Jan 12, 2024

tkusano left a comment

Choose a reason for hiding this comment

dolciss left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

noritada commented Jan 13, 2024

dolciss left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

noritada commented Jan 13, 2024

noritada commented Jan 17, 2024

Hima-Zinn commented Jan 18, 2024 • edited Loading

pfrazee commented Jan 19, 2024

Hima-Zinn commented Jan 19, 2024

noritada commented Jan 21, 2024

noritada commented Jan 21, 2024

noritada commented Jan 21, 2024

pfrazee left a comment

Choose a reason for hiding this comment

noritada commented Jan 12, 2024 •

edited

Loading

oboenikui Jan 12, 2024 •

edited

Loading

Hima-Zinn commented Jan 12, 2024 •

edited

Loading

Hima-Zinn commented Jan 18, 2024 •

edited

Loading