fix rendering of external in quote embeds #2464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External embeds are not currently displayed in a quote post, which results in context loss.
I also think it makes more sense here to remove the
.find()
since - unless this is done in anticipation of future changes - there will never be more than a single embed for a post: https://github.com/bluesky-social/atproto/blob/50f70453a9e49621956e4e820226c0e220fe138e/packages/bsky/src/services/feed/views.ts#L434 (thanks @mary-ext). Instead we just need to get the first possible embed from the array.We do still need to check for types, since we don't want to show a quote's quote.
Of course we could add
but this feels like some additional logic that isn't needed. Correct me if wrong.