Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable spanish translation until it's more thoroughly reviewed #2362

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Disable spanish translation until it's more thoroughly reviewed #2362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b5a3eb
Disable spanish translation until it's more thoroughly reviewed
pfrazee Dec 28, 2023
01a0af7
missed a line
pfrazee Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/locale/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,9 @@ export function sanitizeAppLanguageSetting(appLanguage: string): AppLanguage {
// DISABLED until this translation is fixed -prf
// case 'de':
// return AppLanguage.de
case 'es':
return AppLanguage.es
// DISABLED until this translation is more thoroughly reviewed -prf
// case 'es':
// return AppLanguage.es
default:
continue
}
Expand Down
12 changes: 7 additions & 5 deletions src/locale/i18n.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ import {messages as messagesJa} from '#/locale/locales/ja/messages'
import {messages as messagesFr} from '#/locale/locales/fr/messages'
// DISABLED until this translation is fixed -prf
// import {messages as messagesDe} from '#/locale/locales/de/messages'
import {messages as messagesEs} from '#/locale/locales/es/messages'
// DISABLED until this translation is more thoroughly reviewed -prf
// import {messages as messagesEs} from '#/locale/locales/es/messages'

import {sanitizeAppLanguageSetting} from '#/locale/helpers'
import {AppLanguage} from '#/locale/languages'
Expand All @@ -35,10 +36,11 @@ export async function dynamicActivate(locale: AppLanguage) {
// i18n.loadAndActivate({locale, messages: messagesDe})
// break
// }
case AppLanguage.es: {
i18n.loadAndActivate({locale, messages: messagesEs})
break
}
// DISABLED until this translation is more thoroughly reviewed -prf
// case AppLanguage.es: {
// i18n.loadAndActivate({locale, messages: messagesEs})
// break
// }
default: {
i18n.loadAndActivate({locale, messages: messagesEn})
break
Expand Down
9 changes: 5 additions & 4 deletions src/locale/i18n.web.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,11 @@ export async function dynamicActivate(locale: AppLanguage) {
// mod = await import(`./locales/de/messages`)
// break
// }
case AppLanguage.es: {
mod = await import(`./locales/es/messages`)
break
}
// DISABLED until this translation is more thoroughly reviewed -prf
// case AppLanguage.es: {
// mod = await import(`./locales/es/messages`)
// break
// }
default: {
mod = await import(`./locales/en/messages`)
break
Expand Down
6 changes: 4 additions & 2 deletions src/locale/languages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ export enum AppLanguage {
fr = 'fr',
// DISABLED until this translation is fixed -prf
// de = 'de',
es = 'es',
// DISABLED until this translation is more thoroughly reviewed -prf
// es = 'es',
}

interface AppLanguageConfig {
Expand All @@ -26,7 +27,8 @@ export const APP_LANGUAGES: AppLanguageConfig[] = [
{code2: AppLanguage.fr, name: 'Français'},
// DISABLED until this translation is fixed -prf
// {code2: AppLanguage.de, name: 'Deutsch'},
{code2: AppLanguage.es, name: 'Español'},
// DISABLED until this translation is more thoroughly reviewed -prf
// {code2: AppLanguage.es, name: 'Español'},
]

export const LANGUAGES: Language[] = [
Expand Down