Fix: Some display issues #2219
Merged
Fix: Some display issues #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I propose a CSS fix to correctly display the translated versions of the Before patch: After this patch applied: diff --git a/src/view/shell/desktop/RightNav.tsx b/src/view/shell/desktop/RightNav.tsx
index c126935d..8d9961a5 100644
--- a/src/view/shell/desktop/RightNav.tsx
+++ b/src/view/shell/desktop/RightNav.tsx
@@ -52,7 +52,7 @@ export function DesktopRightNav() {
</Text>
</View>
) : undefined}
- <View style={[s.flexRow]}>
+ <View style={[{flexWrap: 'wrap'}, s.flexRow]}>
{hasSession && (
<>
<TextLink |
|
Thank you very much. |
|
@tkusano In addition, since the content handled is now general display systems, I will change the title to an appropriate one. |
Hima-Zinn
changed the title
|
This looks good. Thank you @Hima-Zinn |
estrattonbailey
added a commit
that referenced
this pull request
Dec 18, 2023
* origin/main: (22 commits) basic public RSS feed for profiles (#2229) use `s.likeColor` everywhere (#2234) Add credits to localization doc (#2233) Fix `Logotype` fill for dark mode (#2230) Hide label appeal on self-labeled posts (#2232) Fix & Add: Japanese Translation (3) (#2226) tweak social card meta yet again (#2228) bskyweb: update golang indigo dep (from May!), and some small devex tweaks (#2227) Fix: Some display issues (#2219) Update splash screen tagline, update translations, bump ios build number Bump ios build number Tweaks (#2225) 1.60 Traffic reduction and tuned caching strats (#2215) Super secret changes don't look (#2218) Fix android icon dims (#2213) Log post creation failures (#2205) Some brand, some pwi (#2212) 🤫 (#2211) PWI behavior updates (#2207) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(English ver. by BIng Translation)
cf： #2209 (comment) ( @tkusano )
Dear Administrators of this Repository,
Hello.
When I was working on Japanese localization ( #2209 (comment) ), a colleague discovered a problem that the GUI display was distorted in the early version of Japanese and that "Profile" was not displayed in Japanese.
With this fix, "NewPost" and "Profile" will be displayed correctly in the selected language, and other languages will be served more smoothly.
I hope you will join us in Merge.
Hima
(Original (Japanese))
関連： #2209 (comment) ( @tkusano )
このリポジトリの管理者のみなさん
こんにちは。
日本語のローカライズ作業をしていた（ #2209 (comment) ）際、日本語の初期バージョンでGUIの表示が乱れ、また"Profile"が日本語で表示されない問題を仲間が発見してくれました。
この修正により、"NewPost"と"Profile"が選択した言語で正しく表示されるようになり、また他の言語の提供もスムーズになると思われます。
ぜひ、Mergeしていただければ幸いです。
Hima