Fix scroll on profile lists/feeds #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Dec 11, 2023
| @@ -20,7 +20,7 @@ import {OnScrollHandler} from '#/lib/hooks/useOnMainScroll' | |||
| import {logger} from '#/logger' | |||
| import {Trans} from '@lingui/macro' | |||
| import {cleanError} from '#/lib/strings/errors' | |||
| import {useAnimatedScrollHandler} from 'react-native-reanimated' | |||
| import {useAnimatedScrollHandler_FIXED} from '#/lib/hooks/useAnimatedScrollHandler_FIXED' | |||
gaearon
commented
Dec 11, 2023
| @@ -19,7 +19,7 @@ import {OnScrollHandler} from '#/lib/hooks/useOnMainScroll' | |||
| import {logger} from '#/logger' | |||
| import {Trans} from '@lingui/macro' | |||
| import {cleanError} from '#/lib/strings/errors' | |||
| import {useAnimatedScrollHandler} from 'react-native-reanimated' | |||
| import {useAnimatedScrollHandler_FIXED} from '#/lib/hooks/useAnimatedScrollHandler_FIXED' | |||
pfrazee
approved these changes
Dec 11, 2023
Merged
estrattonbailey
added a commit
that referenced
this pull request
Dec 12, 2023
…japanese * origin/main: (32 commits) i18n settings improvements (#2184) 1.58 Double the footer on the list members flatlist Fix links in profiles (#2178) Patch bad migration, sanitize bad value (#2179) Hide the mobile reply control if outside the threadgate (#2177) Revise FeedSourceCard load state to allow deletion for failures (#2172) Handle failed pinned feed fetches when rendering list of pinned feeds (#2173) Don't validate embeds when traversing cache (#2174) dismiss keyboard when threadgate settings are opened (#2161) Clarify MyList filter intent (#2167) Additional reductions in request traffic (#2169) Fix scroll on native (#2170) Fix scroll on profile lists/feeds (#2168) Reduce calls to getFeedGenerator and getFeed (#2166) Bump ios and android build numbers Fix mock-server init Add "Who can reply" controls [WIP] (#1954) Bump ios build Fix empty state width (#2157) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It didn't work due to software-mansion/react-native-reanimated#5488.
We already had a workaround checked in, but it wasn't prominent enough so old imports slipped through.
I renamed the export name itself consistently and added it in the places that missed it so that it's harder to copy paste the wrong thing.
Without whitespace