Update clear account behavior, ensure agent is set #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estrattonbailey
commented
Nov 13, 2023
| @@ -178,6 +178,7 @@ export function Provider({children}: React.PropsWithChildren<{}>) { | |||
| }), | |||
| ) | |||
|
|
|||
| setState(s => ({...s, agent})) | |||
There was a problem hiding this comment.
Set agent after login, was missing this
estrattonbailey
commented
Nov 13, 2023
Comment on lines
+377
to
+384
| /** | ||
| * Clears the `currentAccount` from session. Typically used to drop the user | ||
| * back to the sign-in page. | ||
| */ | ||
| const clearCurrentAccount = React.useCallback(() => { | ||
| setStateAndPersist(s => ({ | ||
| ...s, | ||
| agent: PUBLIC_BSKY_AGENT, |
There was a problem hiding this comment.
This is a soft log out. The user was authed and wanted to sign in with a different account.
estrattonbailey
commented
Nov 13, 2023
Comment on lines
+434
to
+437
| clearCurrentAccount() | ||
| } | ||
| }) | ||
| }, [state, logout, initSession]) | ||
| }, [state, clearCurrentAccount, initSession]) |
There was a problem hiding this comment.
This happens in response to a broadcast channel update. A user could simply be adding a new account, in which case we don't want to nuke their tokens.
If a user does logout, this still still be called, and the other tab will have already nuked their tokens, so same difference.
pfrazee
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.