Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drive-by lightbox refactors #1659

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Drive-by lightbox refactors #1659

merged 3 commits into from
Oct 10, 2023

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Oct 10, 2023

No behavior change, just cleaning up before more significant changes.

  • b274de6: Removes support for passing a number as image source. This used to be a lie in the types, and we don't use this feature anyway. (In the original library, this was used to support showing local images from disk.) Also removes the keyExtractor prop which we're not using anywhere.
  • 2464c8f: Renames the prop to clarify it's only used to seed the initial state.
  • bd7ef0c: Renames the state variable.

@gaearon gaearon requested a review from pfrazee October 10, 2023 17:39
pfrazee
pfrazee approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pfrazee pfrazee merged commit d47ff54 into main Oct 10, 2023
@pfrazee pfrazee deleted the lightbox-rf branch October 10, 2023 18:07
estrattonbailey added a commit that referenced this pull request Oct 11, 2023
@estrattonbailey
Merge remote-tracking branch 'origin' into eric/app-864-integrate-pos…
7a97c3c 
…t-tags-into-app

* origin: (21 commits)
  resolve fork of zeed-dom (#1663)
  Port remaining lightbox code to Reanimated (#1669)
  Update testrunner to use new dev-env [WIP] (#1575)
  Fix MobX crash for Android lightbox (#1668)
  Change lightbox to use Pager (#1666)
  make empty feed required (#1667)
  Only warn on links to bsky.app if it represents itself as another url (#1662)
  Fix keyboard double pad issue in email change & verify modals (#1664)
  Don't highlight tags in composer yet (#1665)
  Fix: fetch follows on desktop search for typeahead (#1660)
  Remove duplicate modal container (#1661)
  Drive-by lightbox refactors (#1659)
  Only prompt users once to verify email (according to local storage) close #1657 (#1658)
  Revert "Fix invite codes flash on desktop, use loading placeholder (#1591)" (#1656)
  Refactor iOS lightbox to Reanimated (#1645)
  Bump package.json to 1.52
  Remove unnecessary opacity logic (#1646)
  Fix typo in image.ts (#1638)
  fix typo README.md (#1631)
  Typo fix in README.md: "small about" -> "small amount" (#1639)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfrazee pfrazee pfrazee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaearon @pfrazee