Signing out an account is signing out all accounts

[xtianpu]

Describe the bug
Signing out an account is signing out all accounts

To Reproduce

Steps to reproduce the behavior:

1. Press sign out button on settings

Expected behavior

Should be only one account to be signed out, and switch to another signed in account

Details

• Platform: All platform
• Platform version: -
• App version: v1.87.0

[swar00p]

Is this the expected behavior? I tried it on my iOS app and confirmed that I get signed out of both my accounts if I click on Sign Out on one of them. I'm a complete newbie but I cloned the code base on my laptop and took a quick look. I may be mistaken but it looks like the logout method in

social-app/src/state/session/index.tsx

Line 117 in ea0586c

const logout = React.useCallback<SessionApiContext['logout']>(

doesn't accept an account parameter.

I'm happy to dig in a bit more to see what's going on.

[haileyok]

@swar00p Definitely is not expected behavior. Feel free to do some digging on it if you feel like it! ❤️

[xtianpu]

@swar00p @haileyok oh sorry, this should be feature request, my bad assigned it as label bug. Should I close this and create a new one?

[haileyok]

I think bug is fine - it feels like a bug to me 🙃

[xtianpu]

Just create a new one with feature request label #4775

[swar00p]

Just create a new one with feature request label #4775

@xtianpu I think @haileyok said that this should remain open. There was no need to create a feature request. Can you please close the feature request and reopen this bug?

[swar00p]

@haileyok I think I was wrong. The way it's been implemented in

social-app/src/state/session/reducer.ts

Line 145 in 7c1c24e

case 'logged-out': {

and judging by the comment, it looks like it was deliberately implemented this way (to sign out of all accounts). Who makes the decision (one way or another) whether it should continue to work this way or if it should be implemented as a sign out for the selected account only?

[haileyok]

@swar00p Yea, that is the way it was implemented, though we are fine with changing it. It's something that we'll change at some point, but do feel free to look into it yourself and PR if you want to! Also can just take the discussion to the other issue (either label really works here, it does seem like a bug and I personally would consider it one, but I digress 😆)

[haileyok]

(To clarify, we did discuss this a bit internally and are fine with making the change)

[swar00p]

@haileyok I'm using Android Studio as my IDE. My current set up is that I have cloned the social-app project from the repository. I read the instructions in Github to submit PRs and it says that I have to fork the project and then clone it. Is it mandatory to fork the repository or is it sufficient if I just clone it?

[haileyok]

Looks like you figured this out ^, looks like the right idea. Just submit a PR from that fork whenever.