Advanced event filters #22
Conversation
|
Your Render PR Server URL is https://ozone-sandbox-pr-22.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cmufl7nqd2ns73atvu20. |
|
Your Render PR Server URL is https://ozone-staging-pr-22.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cmufl7vqd2ns73atvu7g. |
| @@ -427,7 +427,7 @@ function Form( | |||
| } | |||
| } | |||
| `}</style> | |||
| <div className="flex overflow-y-auto scrollable-container"> | |||
There was a problem hiding this comment.
make room for the ring around the Configure button in the mod event list header.
| @@ -37,7 +37,7 @@ export function FullScreenActionPanel(props: { | |||
| leaveFrom="opacity-100 scale-100" | |||
| leaveTo="opacity-0 scale-95" | |||
| > | |||
| <Dialog.Panel className="max-w-screen-lg w-full sm:w-5/6 h-full md:max-h-3/4 md:my-12 align-bottom bg-white rounded-lg text-left sm:overflow-hidden shadow-xl transform transition-all sm:align-middle flex"> | |||
| <Dialog.Panel className="max-w-screen-xl w-full sm:w-5/6 h-full md:max-h-3/4 md:my-12 align-bottom bg-white rounded-lg text-left sm:overflow-hidden shadow-xl transform transition-all sm:align-middle flex"> | |||
There was a problem hiding this comment.
Make room for the filter panel's content in the event list
package.json
Outdated
| @@ -17,7 +17,7 @@ | |||
| "e2e:run": "$(yarn bin)/cypress run" | |||
| }, | |||
| "dependencies": { | |||
| "@atproto/api": "0.9.2", | |||
| "@atproto/api": "link:../atproto/packages/api/dist", | |||
There was a problem hiding this comment.
Will clean this up before merging
components/mod-event/EventList.tsx
Outdated
| onKeyDown={(e) => { | ||
| if (e.key === 'Enter') { | ||
| e.preventDefault() // make sure we don't submit the form | ||
| e.currentTarget.click() // simulate a click on the input |
There was a problem hiding this comment.
Having trouble picturing it—what happens in the ui when the user presses enter?
There was a problem hiding this comment.
hmm... we're not using this inside a form so this is not necessary so I'm guessing it was just copy-paste thingy. getting rid of it.
| createdBy: undefined, | ||
| subject: undefined, | ||
| oldestFirst: false, | ||
| createdBefore: new Date().toISOString().split('.')[0], |
There was a problem hiding this comment.
This little snippet is used a few places. It's hard to picture exactly what it does, or where that date format is needed. Maybe just pulling it into a helper with a short comment would clear things up.
| } | ||
|
|
||
| useEffect(() => { | ||
| if (props.subject !== listState.subject) { |
There was a problem hiding this comment.
No biggie either way, but these checks for no-ops might make sense to move into the reducer so that dispatch() can be called more freely.
|
|
||
| const EMPTY_ARR = [] | ||
| type SelectProps = React.ComponentProps<typeof Select> | ||
|
|
||
| // TODO: Probably redundant |
There was a problem hiding this comment.
This is just cleaning up unused code.
…advanced-event-filters
There was a problem hiding this comment.
generally good, a few functional things:
- if you select no event types, I think you get all, or generic? seems like it should be empty
- it doesn't seem like the report, by-type works. I tried "spam" and "appeals" in in both cases had all sorts of reports mixed in
otherwise looks good!
I'm not sure if there's a use-case for not selecting any type? the result would always be empty list, right? may be the UI can prevent unselecting all items from the list to avoid this confusion?
Seems like there's an issue with entryway PDS missing lexicons. Devin said he will sync it up later today. I'll put a hold on this until that's done. |
|
Alright after Devin sent out the lexicon changes to entryway, all filters are working! Going to merge now. |
Depends on: bluesky-social/atproto#2124
advanced_event_filters_sm.mov
This PR changes the way moderation events are filtered/configured. Instead of the basic dropdown filter for specific event types, moderators now have a fully configurable filter panel that allows them to use all available filters/params on the
queryModerationEventsendpoint.