✨ Show subtitles in videos, if there are any #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
foysalit
commented
Sep 11, 2024
foysalit
commented
arcalinea
temporarily deployed
to
video-captions - ozone-staging PR #187
Render
Destroyed
arcalinea
temporarily deployed
to
video-captions - ozone-staging PR #187
Render
Destroyed
devinivy
reviewed
Sep 11, 2024
| @@ -233,12 +233,14 @@ export function PostEmbeds({ item }: { item: AppBskyFeedDefs.FeedViewPost }) { | |||
| ) | |||
|
|
|||
| if (AppBskyEmbedVideo.isView(embed)) { | |||
| const captions = item.post.record?.['embed']?.['captions'] | |||
There was a problem hiding this comment.
Where the captions live in the record depends on whether it's a video embed, or a record-with-media embed. Would recommend using the lexicon type guards to figure out where to pull it from (will also make it less likely that you get an invalid captions value that causes a UI crash).
There was a problem hiding this comment.
ok I'm gonna merge this for now since this works. for cases that I'm missing here, will circle back and plug those up tomorrow.
devinivy
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.