-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle insets on android 15 #8
Conversation
android/src/main/java/expo/modules/blueskyvideo/FullscreenActivity.kt
Outdated
Show resolved
Hide resolved
} | ||
} else { | ||
// Apply fixed padding for older Android versions | ||
setPadding(0, getStatusBarHeight(), 0, getNavigationBarHeight()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since old versions worked before, do they need special treatment?
ok good feedback, going to go for a different approach |
useController = true | ||
controllerAutoShow = false | ||
controllerHideOnTouch = true | ||
// Prevent hiding of the navigation bar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious why 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quite a few people have requested this, makes it easier to get out of the video since you can't swipe down to dismiss. i think that's the reasoning.
Android 15 defaults to edge-to-edge mode, which means the nav bar was rendering over the controls in fullscreen mode. This PR fixes it while keeping previous versions unchanged