Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle insets on android 15 #8

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Handle insets on android 15 #8

merged 3 commits into from
Dec 20, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Dec 20, 2024

Android 15 defaults to edge-to-edge mode, which means the nav bar was rendering over the controls in fullscreen mode. This PR fixes it while keeping previous versions unchanged

}
} else {
// Apply fixed padding for older Android versions
setPadding(0, getStatusBarHeight(), 0, getNavigationBarHeight())
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since old versions worked before, do they need special treatment?

@mozzius
Copy link
Member Author

mozzius commented Dec 20, 2024

ok good feedback, going to go for a different approach

useController = true
controllerAutoShow = false
controllerHideOnTouch = true
// Prevent hiding of the navigation bar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quite a few people have requested this, makes it easier to get out of the video since you can't swipe down to dismiss. i think that's the reasoning.

@gaearon gaearon merged commit 3b3095d into main Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants