Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of too big events #2923

Closed
wants to merge 1 commit into from
Closed

Fix handling of too big events #2923

wants to merge 1 commit into from

Conversation

dholms
Copy link
Collaborator

@dholms dholms commented Oct 29, 2024

We were using the wrong method on BlockMap here: the async .add which serializes & hashes the content instead of the synchronous .set since we already know the bytes & cid for the block

Closes #2893

@dholms
Copy link
Collaborator Author

dholms commented Oct 29, 2024

closing in favor of #2894

@dholms dholms closed this Oct 29, 2024
@dholms dholms deleted the too-big-handling branch October 29, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firehose consumers do not receive root block in case of too big seq commit
1 participant