Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ponyfill URL.canParse #2835

Merged
merged 1 commit into from
Sep 27, 2024
Merged

ponyfill URL.canParse #2835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lemon-bags-tan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@atproto/common-web": patch
---

ponyfill URL.canParse
14 changes: 13 additions & 1 deletion packages/common-web/src/did-doc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,13 +145,25 @@ const validateUrl = (urlStr: string): string | undefined => {
return undefined
}

if (!URL.canParse(urlStr)) {
if (!canParseUrl(urlStr)) {
return undefined
}

return urlStr
}

const canParseUrl =
URL.canParse ??
// URL.canParse is not available in Node.js < 18.17.0
((urlStr: string): boolean => {
try {
new URL(urlStr)
return true
} catch {
return false
}
})

// Types
// --------

Expand Down