Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix appealed param's usage #2777

Merged
merged 1 commit into from
Sep 2, 2024
Merged

🐛 Fix appealed param's usage #2777

merged 1 commit into from
Sep 2, 2024

Conversation

foysalit
Copy link
Contributor

@foysalit foysalit commented Sep 2, 2024

Since the appealed param is sent via GET request, expecting it to be null is not reliable so this fix expects it to be either boolean or undefined. This allows the callers to either see only appeals or no appeals or make the response indifferent of appealed status.

@devinivy devinivy merged commit 8252c65 into main Sep 2, 2024
10 checks passed
@devinivy devinivy deleted the fix-appeal-query-param branch September 2, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants