Ensure presence of DPoP related response headers #2711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieusieben
force-pushed
the
msieben/oauth-error-headers
branch
from
6da2fa0 to
569335f
Compare
matthieusieben
force-pushed
the
msieben/oauth-error-headers
branch
from
569335f to
aa5b747
Compare
Merged
estrattonbailey
added a commit
that referenced
this pull request
Aug 15, 2024
* origin/main: Provide a ponyfill for CustomEvent (#2710) Ensure presence of DPoP related response headers (#2711) prettier ignore changelogs, as changesets not resolving prettier config properly Version packages (#2709) Export `AtpAgentOptions` type from @atproto/api (#2708) tidy Version packages (#2706) Update changeset to better reflect changes (#2707) Client SDK rework (#2483) Allow aud of pds or entryway for service auth tokens on pds (#2694) Version packages (#2692) Lex-cli prettier changes changeset (#2691) Version packages (#2689) PDS - inspect bearer tokens (#2688) Version packages (#2685) Service auth method binding - PDS (#2668) minor typos in descriptions and comments (#2681) Fix run-dev-env-logged command (#2682) Version packages (#2677) Tweak some wording in `oauth-client-browser` readme (#2678)
haileyok
pushed a commit
that referenced
this pull request
Aug 16, 2024
* fix(pds): ensure presence of DPoP related response headers * Expose the request context for AuthVerifier and StreamAuthVerifier as distinct types * Properly type ReqCtx for stream auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to work with DPoP, the
AuthVerifierclass needs to be able to set response headers (here and here).The current catch all handler does not provide the response object to the verifier context, preventing it from setting the headers.
This PRs ensures that the
AuthVerifier'saccessStandardauthentication strategy indeed receives theresobject.