exact matches always show profile regardless of block status #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Jul 19, 2024
haileyok
force-pushed
the
hailey/typeahead-exact-matches
branch
from
acd7f14 to
1f6c064
Compare
devinivy
reviewed
Aug 5, 2024
haileyok
force-pushed
the
hailey/typeahead-exact-matches
branch
from
3e70dcd to
b4c76d5
Compare
devinivy
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In an effort to make it easier to find accounts that either you have blocked or that you have been blocked by, exact matches may continue to return an item in the typeahead endpoint. This isn't a differnet level of information that we already show in a user's blocked accounts list.
Test Plan
Block
carla.test, and see that the typeahead doesn't return that result until the exact phrasecarla.testis provided to the typeahead endpoint.I made some test updates but see that the actor search test is getting skipped, so didn't push that up.