PDS: handle S3 upload timeout more gracefully #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
commented
Apr 19, 2024
| const abortController = new AbortController() | ||
| const timeout = setTimeout( | ||
| () => abortController.abort('upload timed out'), |
There was a problem hiding this comment.
The aws-sdk was throwing the reason passed to abort() away, which was actually a little confusing, so I nixed the message/reason here.
estrattonbailey
added a commit
that referenced
this pull request
Apr 29, 2024
* origin/main: (23 commits) Feed context & sendInteractions impl (#2402) Pass through topics headers (#2447) Version packages (#2446) ✨ Allow muting reporter (#2390) Version packages (#2443) Add `savedFeedsPrefV2` and new methods (#2427) fix(ozone): properly import "lande" ES module (from CJS) (#2441) Appview: remove replies to blocked posts from feeds (#2430) PDS: handle S3 upload timeout more gracefully (#2429) Appview: maintain language info when going out to a suggestions service (#2424) Appview: ensure hydration context tracks viewer did and not full service ref (#2423) ✨ Detect language from record content if lang property is not set (#2301) Version packages (#2422) Add email auth factor tools to API (#2419) Version packages (#2417) Lexicons: email auth factor (#2416) Suggestions skeleton impl (#2403) getSuggestionsSkeleton lexicon (#2399) Version packages (#2401) Appview: support new post search params, viewer context in search (#2409) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes upload timeouts to S3 handled a bit more consistently, and surfaces them to the user in a more legible way.
S3BlobStorefor upload timeouts.S3BlobStoretimeouts to bothputTemp()andputPermanent().PDS_BLOBSTORE_S3_UPLOAD_TIMEOUT_MS, defaulting to20000. The previous timeout was 10sec which was too short in enough cases that it was worth increasing to 20sec.repo.uploadBlobendpoint fails due to a timeout.