lexicons: use 'tid' and 'record-key' formats in lexicons #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My Rust library is ready to handle these new formats correctly and code generating :) |
|
I think this is now a good candidate to merge and deploy. All of these use-points are on query parameters, not records, so there are no old/invalid records to worry about (an issue with some other Lexicon changes). These don't change what is an isn't valid: presumably all of these parameters should already validate against these identifier types. This mostly just improves documentation, and will help with codegen in other languages which have specific types for these string formats. |
Manually resolved conflicts:
lexicons/com/atproto/sync/listRepos.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #2377
We'd probably want to hold off on actually merging this until we've done some dev comms and let the specs and library support PRs sink in.Needs codegen.