Handle db client errors on appview #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholms
reviewed
Aug 16, 2023
| @@ -83,3 +85,5 @@ export class Database { | |||
| } | |||
|
|
|||
| export default Database | |||
|
|
|||
| const onClientError = (err: Error) => dbLogger.error({ err }, 'db client error') | |||
There was a problem hiding this comment.
should we close the connection here? 🤔
There was a problem hiding this comment.
That was my initial reaction too— I had a client.release(err) in there to drop the connection from the pool and close it. But it turns out kysely also has its hands in there, and I was getting a double-release error from the pool which caused its own unhandled error 🙃 I think we should keep an eye on it, but hoping this is good enough for now with the work that the pool and kysely are also doing.
estrattonbailey
pushed a commit
that referenced
this pull request
Aug 17, 2023
handle db client errors on bav
estrattonbailey
added a commit
that referenced
this pull request
Aug 18, 2023
* origin: (21 commits) styleguide Increase CI test matrix size (#1490) tweak author-feed rejects test syntax update test format add repost of reply, update snaps simplify query fix typos include reposted replies in posts_no_replies filter fix bad test syntax fix actor takedown tests use getActor, failing atm only include media posts by post creator Fix condition for viewing soft-deleted followers (#1485) ✨ Expose takendown profile, their follows and followers to mods (#1456) Handle revalidation (#1474) Handle db pool errors on appview (#1483) Handle db client errors on appview (#1481) v0.6.4 ✨ Allow creating moderation action with a duration (#1431) ...
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Sep 26, 2023
handle db client errors on bav
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
handle db client errors on bav
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
…lies * origin: Increase CI test matrix size (bluesky-social#1490) Fix condition for viewing soft-deleted followers (bluesky-social#1485) ✨ Expose takendown profile, their follows and followers to mods (bluesky-social#1456) Handle revalidation (bluesky-social#1474) Handle db pool errors on appview (bluesky-social#1483) Handle db client errors on appview (bluesky-social#1481)
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
* origin: (21 commits) styleguide Increase CI test matrix size (bluesky-social#1490) tweak author-feed rejects test syntax update test format add repost of reply, update snaps simplify query fix typos include reposted replies in posts_no_replies filter fix bad test syntax fix actor takedown tests use getActor, failing atm only include media posts by post creator Fix condition for viewing soft-deleted followers (bluesky-social#1485) ✨ Expose takendown profile, their follows and followers to mods (bluesky-social#1456) Handle revalidation (bluesky-social#1474) Handle db pool errors on appview (bluesky-social#1483) Handle db client errors on appview (bluesky-social#1481) v0.6.4 ✨ Allow creating moderation action with a duration (bluesky-social#1431) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids potential crash on certain kinds of connection errors on appview.