Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default profile for the ROV #593

Merged

Conversation

rafaellehmkuhl
Copy link
Member

This is a proposal and should be validated internally.

cockpit-rov-default-proposal

Fix #537

@rafaellehmkuhl
Copy link
Member Author

rafaellehmkuhl commented Nov 27, 2023

Added a commit with @rjehangir proposal:
Updated with Rusty's latest proposal.

image

@rafaellehmkuhl rafaellehmkuhl force-pushed the new-default-rov-profile branch 2 times, most recently from ba536e8 to 49ed3ce Compare November 27, 2023 18:13
@rafaellehmkuhl rafaellehmkuhl marked this pull request as draft November 27, 2023 23:12
@rafaellehmkuhl rafaellehmkuhl force-pushed the new-default-rov-profile branch from 49ed3ce to 7d47421 Compare November 27, 2023 23:12
@rafaellehmkuhl rafaellehmkuhl force-pushed the new-default-rov-profile branch from 7d47421 to bcfd3bf Compare November 28, 2023 16:17
@rafaellehmkuhl rafaellehmkuhl marked this pull request as ready for review November 28, 2023 16:18
@rafaellehmkuhl
Copy link
Member Author

@rjehangir updated with changes agreed yesterday.

@rafaellehmkuhl rafaellehmkuhl merged commit 71acd74 into bluerobotics:master Nov 28, 2023
7 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the new-default-rov-profile branch November 28, 2023 16:32
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Nov 29, 2023
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Dec 12, 2023
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Dec 12, 2023
ES-Alexander added a commit to bluerobotics/ardusub-zola that referenced this pull request Dec 13, 2023
ES-Alexander added a commit to bluerobotics/ardusub-zola that referenced this pull request Dec 13, 2023
ES-Alexander added a commit to bluerobotics/ardusub-zola that referenced this pull request Dec 13, 2023
@ES-Alexander ES-Alexander added docs-complete Change documentation has been completed and removed docs-needed Change needs to be documented labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-complete Change documentation has been completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We need a new default profile for the ROV
3 participants