Add vehicle discovery

[rafaellehmkuhl]

Fix #1314

[ArturoManzoli]

Also, some UI details to fix:

• In (1), there are repeated expressions "Vehicle Discovery" and "search for vehicles". You could change the text to:
  "This feature allows you to locate and connect to vehicles within your network."

• In (2), The "Search for vehicles" button should be located on the Vehicke network connection (global address) panel, since its part of that config area, not the user.

• In (3) The circular loading element should be on the space between the title and the cation "Searching for vehicles in your network", since there is some free space between those two elements. Or it could be where it is if you remove the excessive space between the title and the caption.

• In (4) '1' and '2' are off-center and '3' could be a filled variant of the button (or another one if you wish) or have a larger margin between the results buttons. This way the user will be able to differentiate those elements intuitively.

(1)

(2)

(3)

(4)

[ArturoManzoli]

For now, while the code is under review, some UI changes are needed.

[rafaellehmkuhl]

Also, some UI details to fix:

• In (1), there are repeated expressions "Vehicle Discovery" and "search for vehicles". You could change the text to:
  "This feature allows you to locate and connect to vehicles within your network."
• In (2), The "Search for vehicles" button should be located on the Vehicke network connection (global address) panel, since its part of that config area, not the user.
• In (3) The circular loading element should be on the space between the title and the cation "Searching for vehicles in your network", since there is some free space between those two elements. Or it could be where it is if you remove the excessive space between the title and the caption.
• In (4) '1' and '2' are off-center and '3' could be a filled variant of the button (or another one if you wish) or have a larger margin between the results buttons. This way the user will be able to differentiate those elements intuitively.

Nice catches! Will change.

[rafaellehmkuhl]

@ArturoManzoli everything fixed!

[ArturoManzoli]

On electron, when starting a fresh app run, both tutorial and vehicle discovery screens are shown. We should display one at a time.
Maybe vehicle discovery first?

[ArturoManzoli]

Just need to fix the dialog stack!

[rafaellehmkuhl]

Just need to fix the dialog stack!

Taking a further look I could see that actually this is a broader problem. There is already a stack being created on some situations like the one you described because we don't have a central coordination around dialogs and also because the Tutorial dialog is forcing itself to appear even when asked not to because it has an internal logic of auto-appearing (which should be outside it, otherwise the application can't control it). You can see it in the screenshot below (captured on master), that shows the user-select dialog on top of the tutorial dialog:

This fix is well beyond the scope of this PR, so I opened #1494 to track that and suggest we go with this as it is.