Frontend: add more checks

.eslintrc.js

@@ -61,6 +61,12 @@ module.exports = {
     'simple-import-sort/exports': 'error',
     'simple-import-sort/imports': 'error',
     'sort-imports': 'off',
+    'import/no-unresolved': 'error',
+    'import/named': 'error',
+    'import/default': 'error',
+    'import/namespace': 'error',
+    'import/no-extraneous-dependencies': 'error',
+    'import/no-mutable-exports': 'error',
     '@typescript-eslint/no-useless-constructor': ['error'],
     '@typescript-eslint/no-non-null-assertion': 'off',
     '@typescript-eslint/no-shadow': ['error'],

.github/workflows/test-and-deploy.yml

@@ -62,6 +62,9 @@ jobs:
       - name: Bun lint
         run: bun --cwd ./core/frontend lint
 
+      - name: Type-checking
+        run: bun --cwd ./core/frontend run type-check
+
       - name: Bun build
         run: bun run --cwd ./core/frontend build
 

core/frontend/package.json

@@ -11,7 +11,8 @@
     "dev": "vite --host",
     "build": "NODE_ENV=production vite build",
     "serve": "echo 'This is a preview server for testing the built website. Please use `dev` command over `serve`.\nStarting preview server in 5 seconds..\n';sleep 5; vite preview",
-    "lint": "eslint --max-warnings=0 --ext .js,.vue --ignore-path .gitignore --ignore-pattern src/components/vue-tour src"
+    "lint": "eslint --max-warnings=0 --ext .js,.vue --ignore-path .gitignore --ignore-pattern src/components/vue-tour src",
+    "type-check": "tsc --noEmit"
   },
   "dependencies": {
     "@google/model-viewer": "^3.0.0",

core/frontend/src/components/kraken/BackAlleyTab.vue

@@ -338,7 +338,7 @@ export default Vue.extend({
         return []
       }
 
-      return (this.manifest as ExtensionData[]).sort(
+      return (this.manifest as ExtensionData[]).sort( // eslint-disable-line no-extra-parens
         (a, b) => (b?.repo_info?.downloads ?? 0) - (a?.repo_info?.downloads ?? 0),
       )
     },

core/frontend/src/components/vehiclesetup/calibration.ts

@@ -57,6 +57,10 @@ class Calibrator {
    * @param {PreflightCalibration} type
    */
   private static start(type: PreflightCalibration): void {
+    const getParamValue = (mapping: Partial<Record<PreflightCalibration, number>>): number => {
+      return mapping[type] ?? 0;
+    };
+
     mavlink2rest.sendMessage({
       header: {
         system_id: 255,
@@ -65,38 +69,38 @@ class Calibrator {
       },
       message: {
         type: MAVLinkType.COMMAND_LONG,
-        param1: {
+        param1: getParamValue({
           [PreflightCalibration.GYROSCOPE]: 1,
           [PreflightCalibration.GYROSCOPE_TEMPERATURE]: 3,
-        }[type] || 0,
+        }),
         param2: type === PreflightCalibration.MAGNETOMETER ? 1 : 0,
         param3: type === PreflightCalibration.PRESSURE ? 1 : 0,
-        param4: {
+        param4: getParamValue({
           [PreflightCalibration.RC]: 1,
           [PreflightCalibration.RC_TRIM]: 2,
-        }[type] || 0,
-        param5: {
+        }),
+        param5: getParamValue({
           [PreflightCalibration.ACCELEROMETER]: 1,
           [PreflightCalibration.BOARD_LEVEL]: 2,
           [PreflightCalibration.ACCELEROMETER_TEMPERATURE]: 3,
           [PreflightCalibration.SIMPLE_ACCELEROMETER]: 4,
-        }[type] || 0,
-        param6: {
+        }),
+        param6: getParamValue({
           [PreflightCalibration.COMPASS_MOTOR_INTERFERENCE]: 1,
           [PreflightCalibration.AIRPSEED]: 2,
-        }[type] || 0,
-        param7: {
+        }),
+        param7: getParamValue({
           [PreflightCalibration.ESC]: 1,
           [PreflightCalibration.BAROMETER_TEMPERATURE]: 3,
-        }[type] || 0,
+        }),
         command: {
           type: MavCmd.MAV_CMD_PREFLIGHT_CALIBRATION,
         },
         target_system: autopilot_data.system_id,
         target_component: 1,
         confirmation: 0,
       },
-    })
+    });
   }
 
   /**

core/frontend/src/one-more-time.ts

@@ -70,7 +70,7 @@ export class OneMoreTime {
       const id = setInterval(() => {
         // Check if object does not exist anymore or if it was destroyed by vue
         // eslint-disable-next-line
-        if (!ref.deref() || ref.deref()._isDestroyed) {
+        if (!ref.deref() || (ref.deref() as any)._isDestroyed) {
           this.stop()
           clearInterval(id)
         }
@@ -131,7 +131,7 @@ export class OneMoreTime {
   }
 
   // Celebrate and dance so free
-  [Symbol.dispose](): void {
+  [(Symbol as any).dispose](): void {
     this.stop()
   }
 

core/frontend/src/types/autopilot/parameter-table.ts

@@ -148,7 +148,7 @@ export default class ParametersTable {
             console.log(`ignoring ${name} : ${parameter}`)
             continue
           }
-          this.metadata[name] = parameter
+          this.metadata[name] = (parameter as Metadata)
         }
       }
     }

core/frontend/src/types/shims-general.ts

@@ -1,25 +1,13 @@
 declare module '*.svg' {
   const value: string
-  export default value
 }
 
 declare module '*.jpg' {
   const value: string
-  export default value
 }
 
 declare module '*.png' {
   const value: string
-  export default value
 }
 
-declare module '*.glb' {
-  const value: string
-  export default value
-}
-
-declare module 'vue-tooltip-directive'
-
-declare module '@/assets/colors/default'
-declare module '@/assets/colors/blue_robotics'
-declare module '@/assets/colors/vuetify'
+declare module 'vue-tooltip-directive'

core/frontend/src/utils/ardupilot_mavlink.ts

@@ -81,10 +81,9 @@ export function getMode(): number {
 }
 
 export async function setMode(mode: number,  tries?: number): Promise<void> {
-  tries = tries || 5
   let current_try = 0
   return new Promise<void>(async (resolve, reject) => {
-    while (getMode() !== mode && current_try < tries) {
+    while (getMode() !== mode && current_try < (tries ?? 5)) {
       current_try += 1
       mavlink2rest.sendCommandLong(
         MavCmd.MAV_CMD_DO_SET_MODE,

core/frontend/tsconfig.json

@@ -5,7 +5,7 @@
     "strict": true,
     "jsx": "preserve",
     "importHelpers": true,
-    "moduleResolution": "bundler",
+    "moduleResolution": "node",
     "moduleDetection": "force",
     "skipLibCheck": true,
     "esModuleInterop": true,
@@ -15,7 +15,6 @@
     "baseUrl": ".",
     "experimentalDecorators": true,
     "types": [
-      "webpack-env",
       "vite/client"
     ],
     "paths": {