Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit maximum log size #2789

Merged
merged 3 commits into from
Jul 6, 2024
Merged

Limit maximum log size #2789

merged 3 commits into from
Jul 6, 2024

Conversation

patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Jul 5, 2024 •
edited
Loading

Helps #2328

@patrickelectric patrickelectric force-pushed the log-limit branch 2 times, most recently from 3a2ffb9 to a176244 Compare July 5, 2024 17:31
@joaoantoniocardoso
Copy link
Member

I'm not exactly sure how to test the logs size, but the changes didn't break anything.

@Williangalvani
Copy link
Member

Williangalvani commented Jul 5, 2024 •
edited
Loading

fix #2591

I'm not exactly sure how to test the logs size, but the changes didn't break anything.

I think we'd need a extension that spams stuff in log to test, maybe the one mentioned in #2591

@patrickelectric patrickelectric marked this pull request as draft July 5, 2024 19:59
@patrickelectric patrickelectric force-pushed the log-limit branch 2 times, most recently from 2e394b4 to 3dd513a Compare July 6, 2024 00:12
@patrickelectric patrickelectric marked this pull request as ready for review July 6, 2024 01:01
@patrickelectric
Copy link
Member Author

@joaoantoniocardoso @Williangalvani it's using standard docker logconfig configuration, a docker inspect can confirm that the settings is there:
image

For further information: https://docs.docker.com/config/containers/logging/local/
https://signoz.io/blog/docker-log-rotation/

@patrickelectric patrickelectric merged commit f4016d2 into bluerobotics:master Jul 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoMario109 JoaoMario109 JoaoMario109 approved these changes

@Williangalvani Williangalvani Awaiting requested review from Williangalvani

@joaoantoniocardoso joaoantoniocardoso Awaiting requested review from joaoantoniocardoso

@voorloopnul voorloopnul Awaiting requested review from voorloopnul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrickelectric @joaoantoniocardoso @Williangalvani @JoaoMario109