Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: tools: mavlink2rest: Update to t0.11.19 #2295

Merged
merged 1 commit into from
Jan 12, 2024
Merged

core: tools: mavlink2rest: Update to t0.11.19 #2295

merged 1 commit into from
Jan 12, 2024

Conversation

patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Jan 5, 2024 •
edited
Loading

@patrickelectric patrickelectric mentioned this pull request Jan 11, 2024
Merged
@rafaellehmkuhl
Copy link
Member

The BlueOS image is not appearing for me.

joaoantoniocardoso
joaoantoniocardoso approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know exactly what to test. BlueOS seems to be working normally.

@joaoantoniocardoso joaoantoniocardoso mentioned this pull request Jan 11, 2024
Closed
rafaellehmkuhl
rafaellehmkuhl approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm testing here with my PR and the buttons2 + s/t axes are appearing correctly in the MANUAL_CONTROL messages. Besides that, commands are working fine.

@rafaellehmkuhl rafaellehmkuhl merged commit e3782b7 into bluerobotics:master Jan 12, 2024
7 checks passed
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Apr 17, 2024
@ES-Alexander
Copy link
Collaborator

"What's new" docs should specify that 1.2 adds support for the extended MANUAL_CONTROL protocol (extra axes? + buttons), e.g. for firmwares like recent ArduSub.

@ES-Alexander ES-Alexander added docs-complete Change documentation has been completed and removed docs-needed Change needs to be documented labels Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaellehmkuhl rafaellehmkuhl rafaellehmkuhl approved these changes

@joaoantoniocardoso joaoantoniocardoso joaoantoniocardoso approved these changes

@Williangalvani Williangalvani Awaiting requested review from Williangalvani

Assignees
No one assigned
Labels
docs-complete Change documentation has been completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrickelectric @rafaellehmkuhl @ES-Alexander @joaoantoniocardoso