Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory leak in case of errors during initialization of a reader #3831

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Oct 4, 2024

No description provided.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 29.29889% with 958 lines in your changes missing coverage. Please review.

Project coverage is 56.02%. Comparing base (ccde336) to head (a277689).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/recorder/format_fmp4.go 22.99% 327 Missing and 18 partials ⚠️
internal/protocols/mpegts/from_stream.go 8.79% 165 Missing and 1 partial ⚠️
internal/protocols/webrtc/from_stream.go 24.22% 113 Missing and 9 partials ⚠️
internal/recorder/format_mpegts.go 30.28% 116 Missing and 6 partials ⚠️
internal/protocols/hls/from_stream.go 20.58% 106 Missing and 2 partials ⚠️
internal/protocols/rtmp/from_stream.go 10.63% 83 Missing and 1 partial ⚠️
internal/servers/webrtc/session.go 66.66% 3 Missing ⚠️
internal/stream/stream_reader.go 90.90% 2 Missing and 1 partial ⚠️
internal/servers/hls/muxer_instance.go 83.33% 1 Missing ⚠️
internal/servers/rtmp/conn.go 80.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3831      +/-   ##
==========================================
- Coverage   56.03%   56.02%   -0.01%     
==========================================
  Files         194      194              
  Lines       19320    19523     +203     
==========================================
+ Hits        10826    10938     +112     
- Misses       7657     7747      +90     
- Partials      837      838       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 4c3ac34 into main Oct 4, 2024
6 of 8 checks passed
@aler9 aler9 deleted the fix/race branch October 4, 2024 22:49
Copy link
Contributor

github-actions bot commented Oct 7, 2024

This issue is mentioned in release v1.9.2 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant