Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hls: support generating streams with multiple audio tracks (#2728) #3793

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Sep 22, 2024

Fixes #2728

This allows to generate HLS playlists and streams with multiple audio tracks. The embedded HLS player was improved with a button, displayed in the top right corner of the screen, that allows to change the audio track.

This has been tested with Chrome and Firefox. There are still compatibility issues with iOS.

Nightly binaries

https://github.com/bluenviron/mediamtx/actions/runs/10980959304

@dams92210
Copy link

Works great after few tests. Thank you!

@aler9 aler9 force-pushed the feature/hls-multitrack branch 2 times, most recently from 73f744f to d237089 Compare October 3, 2024 17:27
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 24.29907% with 81 lines in your changes missing coverage. Please review.

Project coverage is 56.03%. Comparing base (8960cba) to head (ff372bc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/protocols/hls/from_stream.go 20.40% 78 Missing ⚠️
internal/servers/hls/muxer_instance.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3793      +/-   ##
==========================================
- Coverage   56.09%   56.03%   -0.06%     
==========================================
  Files         194      194              
  Lines       19304    19320      +16     
==========================================
- Hits        10828    10826       -2     
- Misses       7638     7657      +19     
+ Partials      838      837       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 4d0ce87 into main Oct 3, 2024
6 of 8 checks passed
@aler9 aler9 deleted the feature/hls-multitrack branch October 3, 2024 17:38
Copy link
Contributor

github-actions bot commented Oct 7, 2024

This issue is mentioned in release v1.9.2 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multiple audio track support in HLS
2 participants