Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playback: add "url" field to recording timespans in /list #3619

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Aug 5, 2024

No description provided.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 55.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 57.07%. Comparing base (dc3b5f4) to head (71ec6a3).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/playback/on_get.go 16.66% 9 Missing and 1 partial ⚠️
internal/playback/on_list.go 71.42% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3619      +/-   ##
==========================================
+ Coverage   57.03%   57.07%   +0.03%     
==========================================
  Files         191      191              
  Lines       19273    19292      +19     
==========================================
+ Hits        10992    11010      +18     
+ Misses       7445     7444       -1     
- Partials      836      838       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 changed the title playback: add "endpoint" field to recording timespans in /list playback: add "url" field to recording timespans in /list Aug 25, 2024
@aler9 aler9 merged commit 6da35c8 into main Aug 25, 2024
7 of 8 checks passed
@aler9 aler9 deleted the feature/endpoint branch August 25, 2024 21:04
Copy link
Contributor

This issue is mentioned in release v1.9.0 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant