Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: support publishing H265 tracks (#3435) #3492

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Jun 19, 2024

Fixes #3435

IMPORTANT NOTE: this doesn't allow to read H265 tracks with WebRTC, just to publish them. The inability to read H265 tracks with WebRTC is not in any way related to the server but depends on browsers and on the fact that they are not legally entitled to embed a H265 decoder inside them.

IMPORTANT NOTE: this doesn't allow to read H265 tracks with WebRTC,
just to publish them. The inability to read H265 tracks with WebRTC is
not in any way related to the server but depends on browsers and on the
fact that they are not legally entitled to embed a H265 decoder inside
them.
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.71%. Comparing base (65d90f7) to head (e3cfb58).

Files Patch % Lines
internal/protocols/webrtc/tracks_to_medias.go 0.00% 2 Missing ⚠️
internal/protocols/webrtc/incoming_track.go 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3492      +/-   ##
==========================================
+ Coverage   56.67%   56.71%   +0.04%     
==========================================
  Files         190      190              
  Lines       19151    19162      +11     
==========================================
+ Hits        10853    10868      +15     
+ Misses       7470     7466       -4     
  Partials      828      828              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit a1dc9f4 into main Jun 19, 2024
8 checks passed
@aler9 aler9 deleted the feature/webrtc-h265 branch June 19, 2024 19:02
Copy link
Contributor

github-actions bot commented Jul 7, 2024

This issue is mentioned in release v1.8.4 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OBS 30.2 Beta 1 - NVENC HEVC encoder fails with mediamtx whip server
1 participant