Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: fix error "Failed to setup RTCP mux" on some readers (#3381) #3449

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Jun 10, 2024

Fixes #3381

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 56.23%. Comparing base (1911294) to head (aa339fc).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/protocols/webrtc/peer_connection.go 77.77% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3449      +/-   ##
==========================================
+ Coverage   56.20%   56.23%   +0.02%     
==========================================
  Files         190      190              
  Lines       19049    19076      +27     
==========================================
+ Hits        10707    10727      +20     
- Misses       7520     7525       +5     
- Partials      822      824       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 4272498 into main Jun 10, 2024
8 checks passed
@aler9 aler9 deleted the fix/webrtc-missing-codec branch June 10, 2024 13:43
Copy link
Contributor

This issue is mentioned in release v1.8.3 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to apply the description for m= section with mid='1': Failed to setup RTCP mux.'
1 participant