Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: support reading G711 16khz tracks (#2848) #3445

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Jun 9, 2024

Fixes #2848

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 72.89720% with 29 lines in your changes missing coverage. Please review.

Project coverage is 56.16%. Comparing base (427fea3) to head (4c8d0be).

Files Patch % Lines
internal/servers/webrtc/session.go 67.14% 15 Missing and 8 partials ⚠️
internal/protocols/webrtc/outgoing_track.go 83.78% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3445      +/-   ##
==========================================
+ Coverage   56.12%   56.16%   +0.04%     
==========================================
  Files         190      190              
  Lines       18962    19044      +82     
==========================================
+ Hits        10642    10696      +54     
- Misses       7506     7525      +19     
- Partials      814      823       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 511b276 into main Jun 9, 2024
8 checks passed
@aler9 aler9 deleted the feature/webrtc-g711-16khz branch June 9, 2024 22:57
Copy link
Contributor

This issue is mentioned in release v1.8.3 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WebRTC] No audio when using G.711 16000 Hz?
1 participant