Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show right server version when server is compiled from source #3409

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented May 30, 2024

No description provided.

@aler9 aler9 force-pushed the feature/version branch 7 times, most recently from a1ceb87 to a16ef00 Compare May 30, 2024 21:10
@aler9 aler9 force-pushed the feature/version branch 2 times, most recently from 9fdefb6 to e2a986c Compare September 5, 2024 12:17
@aler9 aler9 force-pushed the feature/version branch 3 times, most recently from 578beb8 to 8881863 Compare October 5, 2024 20:36
@aler9 aler9 changed the title set server version when compiling from source too show right server version when server is compiled from source Oct 5, 2024
@aler9 aler9 force-pushed the feature/version branch 3 times, most recently from 579cb34 to 03997d8 Compare October 5, 2024 20:43
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.03%. Comparing base (2586782) to head (bc8c998).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/servers/hls/hlsjsdownloader/main.go 0.00% 1 Missing ⚠️
...taticsources/rpicamera/mtxrpicamdownloader/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3409      +/-   ##
==========================================
+ Coverage   56.01%   56.03%   +0.02%     
==========================================
  Files         194      194              
  Lines       19479    19479              
==========================================
+ Hits        10912    10916       +4     
+ Misses       7730     7726       -4     
  Partials      837      837              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 force-pushed the feature/version branch 2 times, most recently from 8707bc7 to 07f5a41 Compare October 5, 2024 20:54
@aler9 aler9 merged commit c716947 into main Oct 5, 2024
7 of 8 checks passed
@aler9 aler9 deleted the feature/version branch October 5, 2024 21:10
Copy link
Contributor

github-actions bot commented Oct 7, 2024

This issue is mentioned in release v1.9.2 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant