Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtsp: fix authentication when algorithm field is not supported (#3116) #3314

Merged
merged 1 commit into from
May 15, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented May 3, 2024

Fixes #3116

Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 52.68%. Comparing base (c0ad6e4) to head (1135709).

Files Patch % Lines
internal/auth/manager.go 50.00% 0 Missing and 2 partials ⚠️
internal/conf/rtsp_auth_methods.go 33.33% 2 Missing ⚠️
internal/conf/conf.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3314      +/-   ##
==========================================
- Coverage   52.68%   52.68%   -0.01%     
==========================================
  Files         194      194              
  Lines       20016    20015       -1     
==========================================
- Hits        10545    10544       -1     
+ Misses       8615     8613       -2     
- Partials      856      858       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 changed the title fix authentication with cameras that don't support explicit algorithm (#3116) rtsp: fix authentication when "algorithm" field is not supported (#3116) May 4, 2024
@aler9 aler9 changed the title rtsp: fix authentication when "algorithm" field is not supported (#3116) rtsp: fix authentication when algorithm field is not supported (#3116) May 4, 2024
@aler9 aler9 merged commit f3ed659 into main May 15, 2024
6 of 8 checks passed
@aler9 aler9 deleted the fix/auth branch May 15, 2024 08:28
Copy link
Contributor

This issue is mentioned in release v1.8.2 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTSP Source 401 after v1.6.0
1 participant