fix support for JWT authentication in API, metrics, playback, pprof #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aler9 do you have time do review this PR? |
I've made some modifications related to JWT authentication that I would like to bring to your attention. It appears that token validation was not being performed in the methods listed below. Additionally, I attempted to integrate it with HLS, but encountered some issues. It might be beneficial to review these changes to ensure everything is functioning as expected. Modified Files: internal/api/api.go internal/metrics/metrics.go internal/playback/server.go internal/pprof/pprof.go Your feedback and review on these changes would be greatly appreciated. Please let me know if there are any concerns or if further adjustments are needed. Thank you for your attention to this matter.
aler9
changed the title
|
i added tests and merged, thanks! |
13 tasks
|
This issue is mentioned in release v1.8.0 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made some modifications related to JWT authentication that I would like to bring to your attention. It appears that token validation was not being performed in the methods listed below. Additionally, I attempted to integrate it with HLS, but encountered some issues. It might be beneficial to review these changes to ensure everything is functioning as expected.
Modified Files:
internal/api/api.go
internal/metrics/metrics.go
internal/playback/server.go
internal/pprof/pprof.go
Your feedback and review on these changes would be greatly appreciated. Please let me know if there are any concerns or if further adjustments are needed.
Thank you for your attention to this matter.