Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hls: fix crash when muxer is being recreated, improve performance #3017

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Feb 13, 2024

No description provided.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 181 lines in your changes are missing coverage. Please review.

Comparison is base (b6eaa6b) 53.65% compared to head (d96ca4c) 53.59%.

Files Patch % Lines
internal/servers/hls/muxer_instance.go 40.32% 101 Missing and 10 partials ⚠️
internal/servers/hls/muxer.go 51.80% 40 Missing ⚠️
internal/servers/srt/conn.go 0.00% 22 Missing ⚠️
internal/core/path.go 75.00% 3 Missing ⚠️
internal/core/path_manager.go 70.00% 3 Missing ⚠️
internal/servers/hls/http_server.go 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3017      +/-   ##
==========================================
- Coverage   53.65%   53.59%   -0.06%     
==========================================
  Files         133      137       +4     
  Lines       13064    13698     +634     
==========================================
+ Hits         7010     7342     +332     
- Misses       5486     5765     +279     
- Partials      568      591      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 1ae3240 into main Feb 13, 2024
6 of 8 checks passed
@aler9 aler9 deleted the fix/hls branch February 13, 2024 22:32
Copy link
Contributor

github-actions bot commented Mar 4, 2024

This issue is mentioned in release v1.6.0 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant